From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75028C433FF for ; Tue, 30 Jul 2019 15:18:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 090EE20693 for ; Tue, 30 Jul 2019 15:18:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 090EE20693 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsTtY-0006oL-8P for qemu-devel@archiver.kernel.org; Tue, 30 Jul 2019 11:18:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42674) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsTsn-0006Hw-FK for qemu-devel@nongnu.org; Tue, 30 Jul 2019 11:17:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsTsm-0001mN-2p for qemu-devel@nongnu.org; Tue, 30 Jul 2019 11:17:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18622) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsTsa-0001cQ-Pj; Tue, 30 Jul 2019 11:17:33 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7042D335D7; Tue, 30 Jul 2019 15:17:31 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-116-164.ams2.redhat.com [10.36.116.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C8F719C5B; Tue, 30 Jul 2019 15:17:24 +0000 (UTC) To: Kevin Wolf , qemu-block@nongnu.org References: <20190730145727.28965-1-kwolf@redhat.com> <20190730145727.28965-2-kwolf@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Tue, 30 Jul 2019 17:17:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190730145727.28965-2-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9601QJVlMDldqXfCNZXxj96TmKgaT7JiR" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 30 Jul 2019 15:17:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.1 1/2] fdc: Fix inserting read-only media in empty drive X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, philmd@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9601QJVlMDldqXfCNZXxj96TmKgaT7JiR Content-Type: multipart/mixed; boundary="yNlC5k8sRidwY1W8829C9hyUNlXlWn9Pi"; protected-headers="v1" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, philmd@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH for-4.1 1/2] fdc: Fix inserting read-only media in empty drive References: <20190730145727.28965-1-kwolf@redhat.com> <20190730145727.28965-2-kwolf@redhat.com> In-Reply-To: <20190730145727.28965-2-kwolf@redhat.com> --yNlC5k8sRidwY1W8829C9hyUNlXlWn9Pi Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 30.07.19 16:57, Kevin Wolf wrote: > In order to insert a read-only medium (i.e. a read-only block node) to > the BlockBackend of a floppy drive, we must not have taken write > permissions on that BlockBackend, or the operation will fail with the > error message "Block node is read-only". >=20 > The device already takes care to remove all permissions when the medium= > is ejected, but the state isn't correct if the drive is initially empty= : > It uses blk_is_read_only() to check whether write permissions should be= > taken, but this function returns false for empty BlockBackends in the > common case. >=20 > Fix floppy_drive_realize() to avoid taking write permissions if the > drive is empty. =2E..and once the drive is loaded with anything, fd_change_cb() calls blkconf_apply_backend_option() again with the updated RO state. Looks correct. > Signed-off-by: Kevin Wolf > --- > hw/block/fdc.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz --yNlC5k8sRidwY1W8829C9hyUNlXlWn9Pi-- --9601QJVlMDldqXfCNZXxj96TmKgaT7JiR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl1AX4IACgkQ9AfbAGHV z0DisAf/X0uUt7Bjlfjk//4P6XNxLpWrcaGX5G/GJXLD45MoX3tqd9x9i2uPXkny Buf+GXlushBK/pF17TVuW6j7ghEfU7rXpJgIU2rdQ+42hI24bH3xHKp+4ekpAMIl G+LvK+hulC1EPp7AbGVpDJqib6DF42IPmGnNTZpWmaXKUcWncSvm+n72ZGuBt8l6 jnhQf5ahiWTBHfhlqogWmOe3J1qlvLlaku3pNuc4NCxhE5lau5LDgqBA+Ofc2/iQ P2cr5X+iEz9qb1cEVINIbcj8CDHxR7TQb736Y7iAYIIZ5HOwrQhK26Z9ywoMYe/o xHZbpLsjird2pP303aDVSXni0N4WtQ== =ni/o -----END PGP SIGNATURE----- --9601QJVlMDldqXfCNZXxj96TmKgaT7JiR--