From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off
Date: Tue, 19 Jun 2018 17:07:46 -0500 [thread overview]
Message-ID: <f87772ab-7d59-4ab2-59e3-c1ac77eaf725@redhat.com> (raw)
In-Reply-To: <b59883c6-1dc0-4e81-439c-587c8f2d3e83@redhat.com>
On 06/19/2018 10:17 AM, Paolo Bonzini wrote:
> On 16/06/2018 00:29, Michael S. Tsirkin wrote:
>>
>> +static QemuOptsList qemu_dedicated_opts = {
>> + .name = "dedicated",
>> + .head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head),
>> + .desc = {
>> + {
>> + .name = "mem-lock",
>> + .type = QEMU_OPT_BOOL,
>> + },
>> + {
>> + .name = "cpu-pm",
>> + .type = QEMU_OPT_BOOL,
>> + },
>> + { /* end of list */ }
>> + },
>> +};
>> +
>
> Let the bikeshedding begin!
>
> 1) Should we deprecate -realtime?
>
> 2) Maybe -hostresource?
What further things might we add in the future?
-dedicated sounds wrong (it is an adjective, while most of our options
are nouns - thing -machine, -drive, -object, ...)
-hostresource at least sounds like a noun, but is long to type. But at
least '-hostresource cpu-pm=on' reads reasonably well.
About the only other noun I could think of would be '-feature cpu-pm=on'.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-19 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 22:29 [Qemu-devel] [PATCH v3 0/2] kvm: limited x86 CPU power management Michael S. Tsirkin
2018-06-15 22:29 ` [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off Michael S. Tsirkin
2018-06-19 15:17 ` Paolo Bonzini
2018-06-19 20:43 ` Michael S. Tsirkin
2018-06-20 14:20 ` Paolo Bonzini
2018-06-20 14:29 ` Michael S. Tsirkin
2018-06-20 14:45 ` Paolo Bonzini
2018-06-19 22:07 ` Eric Blake [this message]
2018-06-20 0:06 ` Michael S. Tsirkin
2018-06-20 0:46 ` Wanpeng Li
2018-06-20 2:41 ` Michael S. Tsirkin
2018-07-05 5:52 ` Wanpeng Li
2018-06-15 22:29 ` [Qemu-devel] [PATCH v3 2/2] i386/cpu: make -cpu host support monitor/mwait Michael S. Tsirkin
2018-06-16 0:05 ` [Qemu-devel] [PATCH v3 0/2] kvm: limited x86 CPU power management no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87772ab-7d59-4ab2-59e3-c1ac77eaf725@redhat.com \
--to=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).