From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 7/7] m68k: add Virtual M68k Machine
Date: Sun, 24 Jan 2021 11:58:22 +0100 [thread overview]
Message-ID: <f8856f85-cea8-dc07-a88c-a7f03fc96356@vivier.eu> (raw)
In-Reply-To: <dda5766b-8af9-df30-abaf-c4c91c0d5543@amsat.org>
Le 24/01/2021 à 01:18, Philippe Mathieu-Daudé a écrit :
> On 12/20/20 12:26 PM, Laurent Vivier wrote:
>> The machine is based on Goldfish interfaces defined by Google
>> for Android simulator. It uses Goldfish-rtc (timer and RTC),
>> Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty).
>>
>> The machine is created with 128 virtio-mmio bus, and they can
>> be used to use serial console, GPU, disk, NIC, HID, ...
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> default-configs/devices/m68k-softmmu.mak | 1 +
>> .../standard-headers/asm-m68k/bootinfo-virt.h | 18 +
>> hw/m68k/virt.c | 312 ++++++++++++++++++
>> MAINTAINERS | 9 +
>> hw/m68k/Kconfig | 10 +
>> hw/m68k/meson.build | 1 +
>> 6 files changed, 351 insertions(+)
>> create mode 100644 include/standard-headers/asm-m68k/bootinfo-virt.h
>> create mode 100644 hw/m68k/virt.c
> ...
>
>> diff --git a/include/standard-headers/asm-m68k/bootinfo-virt.h b/include/standard-headers/asm-m68k/bootinfo-virt.h
>> new file mode 100644
>> index 000000000000..81be1e092497
>> --- /dev/null
>> +++ b/include/standard-headers/asm-m68k/bootinfo-virt.h
>> @@ -0,0 +1,18 @@
>> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>> +/*
>> +** asm/bootinfo-virt.h -- Virtual-m68k-specific boot information definitions
>> +*/
>> +
>> +#ifndef _UAPI_ASM_M68K_BOOTINFO_VIRT_H
>> +#define _UAPI_ASM_M68K_BOOTINFO_VIRT_H
>> +
>> +#define BI_VIRT_QEMU_VERSION 0x8000
>> +#define BI_VIRT_GF_PIC_BASE 0x8001
>> +#define BI_VIRT_GF_RTC_BASE 0x8002
>> +#define BI_VIRT_GF_TTY_BASE 0x8003
>> +#define BI_VIRT_VIRTIO_BASE 0x8004
>> +#define BI_VIRT_CTRL_BASE 0x8005
>> +
>> +#define VIRT_BOOTI_VERSION MK_BI_VERSION(2, 0)
>> +
>> +#endif /* _UAPI_ASM_M68K_BOOTINFO_MAC_H */
>
> Doesn't this belong to patch #1?
>
No, because in PATCH #1 the m68k-virt machine doesn't exist.
PATCH #1 can be merged outside of this series, it's a generic patch.
Thanks,
Laurent
prev parent reply other threads:[~2021-01-24 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 11:26 [PATCH v2 0/7] m68k: add Virtual M68k Machine Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 1/7] m68k: import bootinfo headers from linux Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 2/7] char: add goldfish-tty Laurent Vivier
2021-01-24 0:13 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 3/7] intc: add goldfish-pic Laurent Vivier
2021-01-24 0:08 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 4/7] m68k: add an interrupt controller Laurent Vivier
2021-01-24 16:46 ` Philippe Mathieu-Daudé
2021-01-25 11:56 ` Laurent Vivier
2021-02-12 18:44 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 5/7] m68k: add a system controller Laurent Vivier
2020-12-20 11:26 ` [PATCH v2 6/7] goldfish_rtc: re-arm the alarm after migration Laurent Vivier
2021-01-23 15:05 ` Laurent Vivier
2021-01-25 23:44 ` Alistair Francis
2021-02-06 14:46 ` Laurent Vivier
2021-02-09 1:49 ` Alistair Francis
2021-01-24 0:15 ` Philippe Mathieu-Daudé
2020-12-20 11:26 ` [PATCH v2 7/7] m68k: add Virtual M68k Machine Laurent Vivier
2021-01-24 0:18 ` Philippe Mathieu-Daudé
2021-01-24 10:58 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8856f85-cea8-dc07-a88c-a7f03fc96356@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).