From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Inès Varhol" <ines.varhol@telecom-paris.fr>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Samuel Tardieu <samuel.tardieu@telecom-paris.fr>,
Arnaud Minier <arnaud.minier@telecom-paris.fr>,
Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`
Date: Sun, 14 Apr 2024 18:19:04 +0200 [thread overview]
Message-ID: <f8878a58-8eb6-4a2d-8e77-d38b11a5d4c1@linaro.org> (raw)
In-Reply-To: <20240414132518.278858-1-ines.varhol@telecom-paris.fr>
Hi Inès,
On 14/4/24 15:24, Inès Varhol wrote:
> The messages for STM32L4x5 tests will be easier to understand with
> `g_assert_cmphex` since the comparisions were made with hexadecimal
"comparisons"
> numbers.
>
> Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
> ---
> tests/qtest/stm32l4x5_exti-test.c | 138 ++++++++++++++--------------
> tests/qtest/stm32l4x5_syscfg-test.c | 74 +++++++--------
> 2 files changed, 106 insertions(+), 106 deletions(-)
$ git grep g_assert_cmpuint.*,\ 0x tests/qtest/stm32*| wc -l
105
Nice cleanup!
$ git grep g_assert_cmpuint.*,\ 0x | wc -l
148
Still 33 to go... (not asking you to do it!).
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-14 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 13:24 [PATCH] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint` Inès Varhol
2024-04-14 16:19 ` Philippe Mathieu-Daudé [this message]
2024-04-14 16:34 ` Inès Varhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8878a58-8eb6-4a2d-8e77-d38b11a5d4c1@linaro.org \
--to=philmd@linaro.org \
--cc=arnaud.minier@telecom-paris.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).