From: Thomas Huth <thuth@redhat.com>
To: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Bin Meng" <bin.meng@windriver.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Gerd Hoffmann" <kraxel@redhat.com>,
"Bandan Das" <bsd@redhat.com>, "Hannes Reinecke" <hare@suse.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH 8/8] meson-build: test-crypto-secret depends on CONFIG_SECRET_KEYRING
Date: Mon, 19 Sep 2022 20:06:43 +0200 [thread overview]
Message-ID: <f89980b4-01ca-8c1c-df7c-e529e1eb8e52@redhat.com> (raw)
In-Reply-To: <20220902165126.1482-9-quintela@redhat.com>
On 02/09/2022 18.51, Juan Quintela wrote:
> With this change "make check" works when configured with --disable-keyring.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> tests/unit/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> index b497a41378..988aed27cb 100644
> --- a/tests/unit/meson.build
> +++ b/tests/unit/meson.build
> @@ -78,7 +78,6 @@ if have_block
> 'test-crypto-hmac': [crypto],
> 'test-crypto-cipher': [crypto],
> 'test-crypto-akcipher': [crypto],
> - 'test-crypto-secret': [crypto, keyutils],
> 'test-crypto-der': [crypto],
> 'test-authz-simple': [authz],
> 'test-authz-list': [authz],
> @@ -122,6 +121,9 @@ if have_block
> if config_host_data.get('CONFIG_EPOLL_CREATE1')
> tests += {'test-fdmon-epoll': [testblock]}
> endif
> + if config_host_data.get('CONFIG_SECRET_KEYRING')
> + tests += {'test-crypto-secret': [crypto, keyutils]}
> + endif
> endif
>
> if have_system
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-09-19 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 16:51 [PATCH 0/8] tests: Make expliction defaults for tests Juan Quintela
2022-09-02 16:51 ` [PATCH 1/8] qtest: "-display none" is set in qtest_init() Juan Quintela
2022-09-19 17:59 ` Thomas Huth
2022-09-20 9:20 ` Thomas Huth
2022-09-02 16:51 ` [PATCH 2/8] qtest: Set "-net none" " Juan Quintela
2022-09-04 13:41 ` Philippe Mathieu-Daudé via
2022-09-02 16:51 ` [PATCH 3/8] tests/acpi: The new default is -vga none Juan Quintela
2022-09-02 16:51 ` [PATCH 4/8] tests/qtest: Add -vga none by default Juan Quintela
2022-09-02 16:51 ` [PATCH 5/8] tests/acpi: Regenerate all needed tables Juan Quintela
2022-09-02 16:51 ` [PATCH 6/8] tests: Fix error strings Juan Quintela
2022-09-04 13:41 ` Philippe Mathieu-Daudé via
2022-09-02 16:51 ` [PATCH 7/8] meson-build: Enable CONFIG_REPLICATION only when replication is set Juan Quintela
2022-09-19 18:05 ` Thomas Huth
2022-09-02 16:51 ` [PATCH 8/8] meson-build: test-crypto-secret depends on CONFIG_SECRET_KEYRING Juan Quintela
2022-09-19 18:06 ` Thomas Huth [this message]
2022-09-20 8:06 ` Daniel P. Berrangé
2022-09-02 17:16 ` [PATCH 0/8] tests: Make expliction defaults for tests Alexander Bulekov
2022-09-19 18:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89980b4-01ca-8c1c-df7c-e529e1eb8e52@redhat.com \
--to=thuth@redhat.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).