From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: keith.busch@intel.com, kwolf@redhat.com, mreitz@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] nvme: Implement Write Zeroes
Date: Fri, 5 May 2017 12:03:40 +0200 [thread overview]
Message-ID: <f8a6ae1b-fc48-4c15-1b15-bd966b00c00e@redhat.com> (raw)
In-Reply-To: <20170505095105.GA6630@lst.de>
On 05/05/2017 11:51, Christoph Hellwig wrote:
>> could you pass BDRV_REQ_MAY_UNMAP for the flags here if the deallocate
>> bit (dword 12 bit 25) is set?
> In fact we should do that unconditonally. The deallocate bit is new
> in 1.3 (which we don't claim to support) and forces deallocating, but
> NVMe already allows for this behavior without the flag (we in fact
> explicitly clarified this in an ECN for 1.2.1).
While that's allowed and it makes sense indeed on SSDs, for QEMU's
typical usage it can lead to fragmentation and worse performance. On
extent-based file systems, write zeroes without deallocate can be
implemented very efficiently with FALLOC_FL_ZERO_RANGE, and there's no
reason not to do it.
Is there anything backwards-incompatible in 1.3 that would make it hard
to just bump the supported version?
Paolo
next prev parent reply other threads:[~2017-05-05 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 9:00 [Qemu-devel] [PATCH] nvme: Implement Write Zeroes Christoph Hellwig
2017-05-05 9:30 ` Paolo Bonzini
2017-05-05 9:51 ` Christoph Hellwig
2017-05-05 10:03 ` Paolo Bonzini [this message]
2017-05-05 10:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a6ae1b-fc48-4c15-1b15-bd966b00c00e@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).