From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-s390x@nongnu.org
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check
Date: Wed, 14 Feb 2018 17:26:03 +0100 [thread overview]
Message-ID: <f8ad6605-be41-500c-bf2f-0c51d7d5dc84@redhat.com> (raw)
In-Reply-To: <3af03376-af1b-ba46-f545-f71e80f834fd@twiddle.net>
On 14.02.2018 17:05, Richard Henderson wrote:
> On 02/14/2018 07:25 AM, David Hildenbrand wrote:
>> /* SET CLOCK COMPARATOR */
>> - C(0xb206, SCKC, S, Z, 0, m2_64, 0, 0, sckc, 0)
>> + C(0xb206, SCKC, S, Z, 0, a2, 0, 0, sckc, 0)
>
> Rather than move the memory load into the op_ functions, better to add an
> m2_64a (etc) functions that apply the alignment.
Jup, also had that in mind, moves the magic to a different place. Will
play with it.
>
>
> r~
>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2018-02-14 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:25 [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check David Hildenbrand
2018-02-14 16:05 ` Richard Henderson
2018-02-14 16:26 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8ad6605-be41-500c-bf2f-0c51d7d5dc84@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).