From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elzt1-0002uw-Kt for qemu-devel@nongnu.org; Wed, 14 Feb 2018 11:26:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elzt0-0001pq-Sd for qemu-devel@nongnu.org; Wed, 14 Feb 2018 11:26:23 -0500 References: <20180214152544.26925-1-david@redhat.com> <3af03376-af1b-ba46-f545-f71e80f834fd@twiddle.net> From: David Hildenbrand Message-ID: Date: Wed, 14 Feb 2018 17:26:03 +0100 MIME-Version: 1.0 In-Reply-To: <3af03376-af1b-ba46-f545-f71e80f834fd@twiddle.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, Alexander Graf , Cornelia Huck On 14.02.2018 17:05, Richard Henderson wrote: > On 02/14/2018 07:25 AM, David Hildenbrand wrote: >> /* SET CLOCK COMPARATOR */ >> - C(0xb206, SCKC, S, Z, 0, m2_64, 0, 0, sckc, 0) >> + C(0xb206, SCKC, S, Z, 0, a2, 0, 0, sckc, 0) > > Rather than move the memory load into the op_ functions, better to add an > m2_64a (etc) functions that apply the alignment. Jup, also had that in mind, moves the magic to a different place. Will play with it. > > > r~ > -- Thanks, David / dhildenb