From: "Cédric Le Goater" <clg@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>,
Leonardo Bras <leobras.c@gmail.com>
Cc: Bharata B Rao <bharata.rao@in.ibm.com>,
Leonardo Bras <leonardo@linux.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Bharata B Rao <bharata@linux.ibm.com>
Subject: Re: [RESEND PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2
Date: Thu, 14 May 2020 08:05:17 +0200 [thread overview]
Message-ID: <f8b3daef-960f-3e74-0b10-00d30acef00a@kaod.org> (raw)
In-Reply-To: <20200512034109.GX2183@umbus.fritz.box>
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -446,7 +446,8 @@ static int spapr_dt_dynamic_memory_v2(SpaprMachineState *spapr, void *fdt,
>> g_assert(drc);
>> elem = spapr_get_drconf_cell(size / lmb_size, addr,
>> spapr_drc_index(drc), node,
>> - SPAPR_LMB_FLAGS_ASSIGNED);
>> + (SPAPR_LMB_FLAGS_ASSIGNED |
>> + SPAPR_LMB_FLAGS_HOTREMOVABLE);
This is missing a ')'
C.
next prev parent reply other threads:[~2020-05-14 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 20:02 [RESEND PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2 Leonardo Bras
2020-05-12 3:41 ` David Gibson
2020-05-14 6:05 ` Cédric Le Goater [this message]
2020-05-14 6:46 ` David Gibson
2020-07-06 17:45 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8b3daef-960f-3e74-0b10-00d30acef00a@kaod.org \
--to=clg@kaod.org \
--cc=bharata.rao@in.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=leobras.c@gmail.com \
--cc=leonardo@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).