From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ1Q-00023R-QC for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJYxM-0007Bp-A6 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:38:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31646) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJYxM-0007AE-0Q for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:38:08 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CBA63003B45 for ; Thu, 25 Apr 2019 07:38:05 +0000 (UTC) References: <20190423212246.3542-1-ehabkost@redhat.com> <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> <20190424181049.GF18406@habkost.net> From: Thomas Huth Message-ID: Date: Thu, 25 Apr 2019 09:38:00 +0200 MIME-Version: 1.0 In-Reply-To: <20190424181049.GF18406@habkost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: mprivozn@redhat.com, Gerd Hoffmann , qemu-devel@nongnu.org, Markus Armbruster On 24/04/2019 20.10, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: >> On 23/04/2019 23.22, Eduardo Habkost wrote: >>> This series adds machine type deprecation information to the >>> output of the `query-machines` QMP command. With this, libvirt >>> and management software will be able to show this information to >>> users and/or suggest changes to VM configuration to avoid >>> deprecated machine types. >>> >>> Eduardo Habkost (3): >>> qapi: SupportStatusInfo struct >>> machine: Use SupportStatusInfo for deprecation info >>> qmp: Add deprecation information to query-machines >>> >>> qapi/common.json | 24 ++++++++++++++++++++++++ >>> qapi/misc.json | 5 ++++- >>> include/hw/boards.h | 7 ++++--- >>> hw/i386/pc_piix.c | 4 +++- >>> hw/ppc/prep.c | 4 +++- >>> vl.c | 19 +++++++++++++++---- >>> tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++ >>> 7 files changed, 80 insertions(+), 10 deletions(-) >>> create mode 100644 tests/acceptance/query_machines.py >> >> Good idea, but some questions come to my mind: >> >> - What about devices? IIRC Gerd wrote a patch series last year that do= es >> something similar for devices... It would be good to synchronize the >> work, so that we do not have two completely interfaces between devic= es >> and machines here in the end... >=20 > My plan is to support this on devices, too. I even had a version > where documentation of SupportStatusInfo mentioned device types, > but I decided to leave that out until we actually implement a > device deprecation info API. >=20 >> >> - Is deprecation as a status enough, or do we want to carry more >> information here? E.g. is the machine maintained or orphan? Is it >> stable or rather experimental? And didn't Gerd have also some >> patches for this last year? ... yes, I think it was this series here= : >> http://lists.gnu.org/archive/html/qemu-ppc/2018-11/msg00039.html >> ... actually, I like that idea with QemuSupportState... maybe you >> could base your work on that series instead? >=20 > We might want to carry more information eventually. The > possibility of extending the data later is the main reason I > called the struct SupportStatusInfo and not just DeprecationInfo. Ok. I was just a little bit afraid that we define an interface here that we have to change again completely once we want to carry more information. For example whether "deprecated" should be a "bool" here, or rather one of the "enum" entries like in Gerd's series. But after reading through https://patchwork.kernel.org/patch/10660677/ again, I think I agree that "deprecated" is orthogonal to the support state, e.g. a device could still be supported (in the sense that there is a maintainer for it), while it has been marked as "deprecated" already. So no more objections from my side here. Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE51C10F03 for ; Thu, 25 Apr 2019 07:43:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6A48217D7 for ; Thu, 25 Apr 2019 07:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6A48217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ2d-0002iz-L5 for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 03:43:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ1Q-00023R-QC for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJYxM-0007Bp-A6 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:38:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31646) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJYxM-0007AE-0Q for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:38:08 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CBA63003B45 for ; Thu, 25 Apr 2019 07:38:05 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-68.ams2.redhat.com [10.36.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7450600C4; Thu, 25 Apr 2019 07:38:01 +0000 (UTC) To: Eduardo Habkost References: <20190423212246.3542-1-ehabkost@redhat.com> <2b1d825f-8bd3-ba25-3e1b-8415aeec8ce6@redhat.com> <20190424181049.GF18406@habkost.net> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: Date: Thu, 25 Apr 2019 09:38:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424181049.GF18406@habkost.net> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 25 Apr 2019 07:38:05 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, Gerd Hoffmann , Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425073800.goTsRmBh-VyocrL1jzFW50i_apf2Tj-oAMsGwX2VBVQ@z> On 24/04/2019 20.10, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: >> On 23/04/2019 23.22, Eduardo Habkost wrote: >>> This series adds machine type deprecation information to the >>> output of the `query-machines` QMP command. With this, libvirt >>> and management software will be able to show this information to >>> users and/or suggest changes to VM configuration to avoid >>> deprecated machine types. >>> >>> Eduardo Habkost (3): >>> qapi: SupportStatusInfo struct >>> machine: Use SupportStatusInfo for deprecation info >>> qmp: Add deprecation information to query-machines >>> >>> qapi/common.json | 24 ++++++++++++++++++++++++ >>> qapi/misc.json | 5 ++++- >>> include/hw/boards.h | 7 ++++--- >>> hw/i386/pc_piix.c | 4 +++- >>> hw/ppc/prep.c | 4 +++- >>> vl.c | 19 +++++++++++++++---- >>> tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++ >>> 7 files changed, 80 insertions(+), 10 deletions(-) >>> create mode 100644 tests/acceptance/query_machines.py >> >> Good idea, but some questions come to my mind: >> >> - What about devices? IIRC Gerd wrote a patch series last year that do= es >> something similar for devices... It would be good to synchronize the >> work, so that we do not have two completely interfaces between devic= es >> and machines here in the end... >=20 > My plan is to support this on devices, too. I even had a version > where documentation of SupportStatusInfo mentioned device types, > but I decided to leave that out until we actually implement a > device deprecation info API. >=20 >> >> - Is deprecation as a status enough, or do we want to carry more >> information here? E.g. is the machine maintained or orphan? Is it >> stable or rather experimental? And didn't Gerd have also some >> patches for this last year? ... yes, I think it was this series here= : >> http://lists.gnu.org/archive/html/qemu-ppc/2018-11/msg00039.html >> ... actually, I like that idea with QemuSupportState... maybe you >> could base your work on that series instead? >=20 > We might want to carry more information eventually. The > possibility of extending the data later is the main reason I > called the struct SupportStatusInfo and not just DeprecationInfo. Ok. I was just a little bit afraid that we define an interface here that we have to change again completely once we want to carry more information. For example whether "deprecated" should be a "bool" here, or rather one of the "enum" entries like in Gerd's series. But after reading through https://patchwork.kernel.org/patch/10660677/ again, I think I agree that "deprecated" is orthogonal to the support state, e.g. a device could still be supported (in the sense that there is a maintainer for it), while it has been marked as "deprecated" already. So no more objections from my side here. Thomas