From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C56C433E0 for ; Wed, 24 Feb 2021 22:55:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FF4264EDD for ; Wed, 24 Feb 2021 22:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FF4264EDD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lF33i-00030m-9w for qemu-devel@archiver.kernel.org; Wed, 24 Feb 2021 17:55:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lF32I-0002Ck-DH for qemu-devel@nongnu.org; Wed, 24 Feb 2021 17:53:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lF32E-0000Qz-44 for qemu-devel@nongnu.org; Wed, 24 Feb 2021 17:53:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614207213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWtFQ+v2znOPw4h3JmBisrmB2fhK36zsmHodIPTR4jw=; b=KmMC3C4X8omfZTi6xV99uTRTdXty0/V7G3Zy2ZvSgEz6EEbdW4lsjFyeb+hSyf1fdRZGdk GR2+RG9/JWYEEv5ZCqO7icQMM2R4/1KX69HuUlsxSXXaxitlF8Q5OKJL66D/MK4oqvdO5r Qihibz+Rh+wPhfPjw9ZZrVLxYfEHsJk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-0imOFckOOdGTBc1ZsL-Y-A-1; Wed, 24 Feb 2021 17:53:29 -0500 X-MC-Unique: 0imOFckOOdGTBc1ZsL-Y-A-1 Received: by mail-wm1-f71.google.com with SMTP id b62so1142116wmc.5 for ; Wed, 24 Feb 2021 14:53:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XWtFQ+v2znOPw4h3JmBisrmB2fhK36zsmHodIPTR4jw=; b=BLSma2mSSVEPRDDof/iVOx4XqBKuhfdVH9uc2rAGolUR8HOhkfMUsds2QgzSUWejrT BryuuM/6ypDH7zJau0cB/3lckiOln+Y/cUkeeGm8DXUlkl/rKNOzPqWK+w6E6CPWChvA mmdRm9h4c1s9vRDL9oKRddL8wBi0U0Fnau2DeCNI96tWP9ofS5FdaWpaBNU/mkAreQoO hTAo14TctdQovNjKWfD0JBSItOdhn7n3bvVZRV+wg/OwNbackprjzMn5lhN4lvldE62B rD7DQUj6YWtghcuOtNHp1qN3cr5F+jp59CnkXesWw+1FPKrxPvUXYA8BHHBnFVOFBrj7 TyCA== X-Gm-Message-State: AOAM530IbehpE7x43k+SPfFDRQmDcq9iaV2nh1npkj9nt8TKDCI9G7EN ZVheU1v+WnpA7MjvJ+2k8wz/0BM03QkxwhS0uCdX4sROOI8Lh1goAJHMXEAxQXUjOUSBDe883jx TZw4ZdkvQj1z9cRcspjDlq/KPD71+FOqk+AhyHiAaKEBl3MTk+U0RGU8suA0Ncx5W X-Received: by 2002:a5d:5710:: with SMTP id a16mr261708wrv.275.1614207208531; Wed, 24 Feb 2021 14:53:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNIjYzJwtX0vwWZoDXwF0rXHGcrZIdZS/7mgD7FWfH7mFBh9V/eldZLH7rLpnhCZtlb1q9Gw== X-Received: by 2002:a5d:5710:: with SMTP id a16mr261690wrv.275.1614207208336; Wed, 24 Feb 2021 14:53:28 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id c3sm5639993wrr.29.2021.02.24.14.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 14:53:27 -0800 (PST) Subject: Re: [PATCH v22 06/17] meson: add target_user_arch To: Eric Blake , Claudio Fontana , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210224133428.14071-1-cfontana@suse.de> <20210224133428.14071-7-cfontana@suse.de> <37da6126-a6eb-a12e-2944-9ac4a232390c@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 24 Feb 2021 23:53:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <37da6126-a6eb-a12e-2944-9ac4a232390c@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 11:35 PM, Eric Blake wrote: > On 2/24/21 3:21 PM, Philippe Mathieu-Daudé wrote: >> On 2/24/21 2:34 PM, Claudio Fontana wrote: >>> the lack of target_user_arch makes it hard to fully leverage the >>> build system in order to separate user code from sysemu code. >>> >>> Provide it, so that we can avoid the proliferation of #ifdef >>> in target code. >>> >>> Signed-off-by: Claudio Fontana >>> Reviewed-by: Alex Bennée >>> >>> [claudio: added changes for new target hexagon] >> >> Again, this line goes ... >> >>> --- >> >> ... here. Else it is not stripped by git-am and ends >> burried in the repository (see commit 940e43aa30e). > > If you are modifying a patch originally written by someone else (that > is, their S-o-b appears first, but your edits mean you also add S-o-b), > it is courteous to include your modifications in the commit log in this > manner. (For an example, see commit 2c4c556e06) > > You're right that it can look fishy if your changlog appears on your own > commit (if you rebased things with no one else touching the patch in > between, just update the commit message as part of that rebase; the > changelog goes after the --- for review in that case). But it's not > completely wrong: you'll see me doing it when wearing my maintainer hat > and preparing a pull request, and modifying my own patch different from > how it was posted on the mailing list while wearing my developr hat > prior to the pull request (see commit c930831446 for an example) In that case that makes sense indeed (although in Claudio's case I find it more confusing). Regards, Phil.