From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kchamart@redhat.com" <kchamart@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"aliang@redhat.com" <aliang@redhat.com>,
"nsoffer@redhat.com" <nsoffer@redhat.com>,
Fam Zheng <fam@euphon.net>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>,
"eblake@redhat.com" <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build
Date: Tue, 30 Apr 2019 18:53:40 -0400 [thread overview]
Message-ID: <f8d5c4bd-13c3-8230-52d8-b877a10c9577@redhat.com> (raw)
In-Reply-To: <5746f6e2-c6bc-23a4-686f-b6943fedbe2c@virtuozzo.com>
On 4/29/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> 27.04.2019 1:15, John Snow wrote:
>> If we add references that don't resolve (or accidentally remove them),
>> it will be helpful to have an error message alerting us to that.
>
> the wording still a bit in conflict with the fact that -n is originally a warning, not error,
> but I don't really care:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
Ah, sorry, I missed that. Not nice to ignore review comments. How about
this:
"If we add references that don't resolve (or accidentally remove them),
it will be helpful to have warning messages alerting us to that.
Further, turn warnings into errors so we can be alerted to these
problems sooner rather than later."
I can fix it in staging. Thank you for your review again.
--js
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: Fam Zheng <fam@euphon.net>,
"aliang@redhat.com" <aliang@redhat.com>,
"kchamart@redhat.com" <kchamart@redhat.com>,
"qemu-stable@nongnu.org" <qemu-stable@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"nsoffer@redhat.com" <nsoffer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build
Date: Tue, 30 Apr 2019 18:53:40 -0400 [thread overview]
Message-ID: <f8d5c4bd-13c3-8230-52d8-b877a10c9577@redhat.com> (raw)
Message-ID: <20190430225340.FV61XqKjqM-Pde2da0u8cwadQyYW31rQKculhj7XBNE@z> (raw)
In-Reply-To: <5746f6e2-c6bc-23a4-686f-b6943fedbe2c@virtuozzo.com>
On 4/29/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> 27.04.2019 1:15, John Snow wrote:
>> If we add references that don't resolve (or accidentally remove them),
>> it will be helpful to have an error message alerting us to that.
>
> the wording still a bit in conflict with the fact that -n is originally a warning, not error,
> but I don't really care:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
Ah, sorry, I missed that. Not nice to ignore review comments. How about
this:
"If we add references that don't resolve (or accidentally remove them),
it will be helpful to have warning messages alerting us to that.
Further, turn warnings into errors so we can be alerted to these
problems sooner rather than later."
I can fix it in staging. Thank you for your review again.
--js
next prev parent reply other threads:[~2019-04-30 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 22:15 [Qemu-devel] [PATCH v3 0/2] docs/interop/bitmaps: rewrite and modernize doc John Snow
2019-04-26 22:15 ` John Snow
2019-04-26 22:15 ` [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build John Snow
2019-04-26 22:15 ` John Snow
2019-04-29 9:17 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:17 ` Vladimir Sementsov-Ogievskiy
2019-04-30 22:53 ` John Snow [this message]
2019-04-30 22:53 ` John Snow
2019-04-26 22:15 ` [Qemu-devel] [PATCH v3 2/2] docs/interop/bitmaps: rewrite and modernize doc John Snow
2019-04-26 22:15 ` John Snow
2019-04-29 9:30 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:30 ` Vladimir Sementsov-Ogievskiy
2019-04-29 13:44 ` Kashyap Chamarthy
2019-04-29 13:44 ` Kashyap Chamarthy
2019-04-30 22:56 ` John Snow
2019-04-30 22:56 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8d5c4bd-13c3-8230-52d8-b877a10c9577@redhat.com \
--to=jsnow@redhat.com \
--cc=aliang@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kchamart@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).