qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
	"Frédéric Barrat" <fbarrat@linux.ibm.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/2] target/ppc: Implement attn instruction on BookS 64-bit processors
Date: Fri, 19 Jan 2024 09:09:18 +1100	[thread overview]
Message-ID: <f8d6fd3e-07c3-4f8f-a4b7-d3e08d94aec0@linaro.org> (raw)
In-Reply-To: <20240118152523.178576-3-npiggin@gmail.com>

On 1/19/24 02:25, Nicholas Piggin wrote:
> +/* attn enable check                                                         */
> +static inline int check_attn_none(CPUPPCState *env)

Don't mark inline ...

> @@ -2150,6 +2170,7 @@ POWERPC_FAMILY(405)(ObjectClass *oc, void *data)
>       dc->desc = "PowerPC 405";
>       pcc->init_proc = init_proc_405;
>       pcc->check_pow = check_pow_nocheck;
> +    pcc->check_attn = check_attn_none;

... since it is never called directly.


r~


  reply	other threads:[~2024-01-18 22:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 15:25 [PATCH v3 0/2] target/ppc: Fix checkstop and add attn instruction Nicholas Piggin
2024-01-18 15:25 ` [PATCH v3 1/2] target/ppc: Make checkstop actually stop the system Nicholas Piggin
2024-01-18 15:25 ` [PATCH v3 2/2] target/ppc: Implement attn instruction on BookS 64-bit processors Nicholas Piggin
2024-01-18 22:09   ` Richard Henderson [this message]
2024-01-23  1:59     ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8d6fd3e-07c3-4f8f-a4b7-d3e08d94aec0@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=fbarrat@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).