From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: berrange@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
Helge Konetzka <hk@zapateado.de>
Subject: Re: [PATCH-for-8.0] ui: return the default console cursor when con == NULL
Date: Mon, 20 Mar 2023 15:35:21 +0100 [thread overview]
Message-ID: <f8d88acd-e485-6c12-8d4f-43650c3ebd0c@linaro.org> (raw)
In-Reply-To: <20230319111017.1319880-1-marcandre.lureau@redhat.com>
On 19/3/23 12:10, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> VNC code relies on con==NULL to mean the default console.
>
Reported-by: Helge Konetzka <hk@zapateado.de>
> Fixes:
> https://gitlab.com/qemu-project/qemu/-/issues/1548
TIL this multi-lines pattern works!
"You can use the closing patterns in multi-line commit
messages or one-liners"
https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern
> Fixes: commit 385ac97f8 ("ui: keep current cursor with QemuConsole")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/console.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ui/console.c b/ui/console.c
> index f3783021e5..6e8a3cdc62 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -2303,6 +2303,9 @@ QemuConsole *qemu_console_lookup_unused(void)
>
> QEMUCursor *qemu_console_get_cursor(QemuConsole *con)
> {
> + if (con == NULL) {
> + con = active_console;
> + }
> return con->cursor;
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-03-20 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 11:10 [PATCH] ui: return the default console cursor when con == NULL marcandre.lureau
2023-03-20 14:35 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8d88acd-e485-6c12-8d4f-43650c3ebd0c@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=hk@zapateado.de \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).