* [PATCH] ui: return the default console cursor when con == NULL
@ 2023-03-19 11:10 marcandre.lureau
2023-03-20 14:35 ` [PATCH-for-8.0] " Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: marcandre.lureau @ 2023-03-19 11:10 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange, Marc-André Lureau, Gerd Hoffmann
From: Marc-André Lureau <marcandre.lureau@redhat.com>
VNC code relies on con==NULL to mean the default console.
Fixes:
https://gitlab.com/qemu-project/qemu/-/issues/1548
Fixes: commit 385ac97f8 ("ui: keep current cursor with QemuConsole")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/console.c b/ui/console.c
index f3783021e5..6e8a3cdc62 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2303,6 +2303,9 @@ QemuConsole *qemu_console_lookup_unused(void)
QEMUCursor *qemu_console_get_cursor(QemuConsole *con)
{
+ if (con == NULL) {
+ con = active_console;
+ }
return con->cursor;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-for-8.0] ui: return the default console cursor when con == NULL
2023-03-19 11:10 [PATCH] ui: return the default console cursor when con == NULL marcandre.lureau
@ 2023-03-20 14:35 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-03-20 14:35 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: berrange, Gerd Hoffmann, Helge Konetzka
On 19/3/23 12:10, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> VNC code relies on con==NULL to mean the default console.
>
Reported-by: Helge Konetzka <hk@zapateado.de>
> Fixes:
> https://gitlab.com/qemu-project/qemu/-/issues/1548
TIL this multi-lines pattern works!
"You can use the closing patterns in multi-line commit
messages or one-liners"
https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern
> Fixes: commit 385ac97f8 ("ui: keep current cursor with QemuConsole")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/console.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ui/console.c b/ui/console.c
> index f3783021e5..6e8a3cdc62 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -2303,6 +2303,9 @@ QemuConsole *qemu_console_lookup_unused(void)
>
> QEMUCursor *qemu_console_get_cursor(QemuConsole *con)
> {
> + if (con == NULL) {
> + con = active_console;
> + }
> return con->cursor;
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 11:10 [PATCH] ui: return the default console cursor when con == NULL marcandre.lureau
2023-03-20 14:35 ` [PATCH-for-8.0] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).