From: Eric Blake <eblake@redhat.com>
To: dverma <dverma@redhat.com>, qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, jen@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/3] Fix format and styles; make code more pythonic
Date: Mon, 7 Aug 2017 13:04:39 -0500 [thread overview]
Message-ID: <f8da5e54-bc7d-583c-0046-5c33040943b3@redhat.com> (raw)
In-Reply-To: <1502124810-6930-2-git-send-email-dverma@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On 08/07/2017 11:53 AM, dverma wrote:
> - Format fixes, cleaned up the print statement
> - Style fixes, e.g. changed "if not x in y" to "if x not in y"
> - Improved variable names
> ---
Missing a Signed-off-by: tag; without that, we can't accept the patch.
Can you please resubmit with that fixed? More hints at
https://wiki.qemu.org/index.php/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-08-07 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 16:53 [Qemu-devel] [PATCH v3 0/3] Vmstate-static-checker.py fix upstream dverma
2017-08-07 16:53 ` [Qemu-devel] [PATCH v3 1/3] Fix format and styles; make code more pythonic dverma
2017-08-07 18:04 ` Eric Blake [this message]
2017-08-07 16:53 ` [Qemu-devel] [PATCH v3 2/3] Update the existing whitelist dverma
2017-08-07 16:53 ` [Qemu-devel] [PATCH v3 3/3] Add new functions for whitelisting and their calls dverma
2017-08-09 0:51 ` [Qemu-devel] [PATCH v3 0/3] Vmstate-static-checker.py fix upstream no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8da5e54-bc7d-583c-0046-5c33040943b3@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dverma@redhat.com \
--cc=jen@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).