From: Anthony PERARD via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: <qemu-devel@nongnu.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>, David Woodhouse <dwmw@amazon.co.uk>
Subject: Re: [PATCH for-8.1] xen: Don't pass MemoryListener around by value
Date: Tue, 18 Jul 2023 15:02:45 +0100 [thread overview]
Message-ID: <f8dcb293-b340-406d-8bdd-84d919f312be@perard> (raw)
In-Reply-To: <20230718101057.1110979-1-peter.maydell@linaro.org>
On Tue, Jul 18, 2023 at 11:10:57AM +0100, Peter Maydell wrote:
> Coverity points out (CID 1513106, 1513107) that MemoryListener is a
> 192 byte struct which we are passing around by value. Switch to
> passing a const pointer into xen_register_ioreq() and then to
> xen_do_ioreq_register(). We can also make the file-scope
> MemoryListener variables const, since nothing changes them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
prev parent reply other threads:[~2023-07-18 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 10:10 [PATCH for-8.1] xen: Don't pass MemoryListener around by value Peter Maydell
2023-07-18 11:21 ` Philippe Mathieu-Daudé
2023-07-18 14:02 ` Anthony PERARD via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8dcb293-b340-406d-8bdd-84d919f312be@perard \
--to=qemu-devel@nongnu.org \
--cc=anthony.perard@citrix.com \
--cc=dwmw@amazon.co.uk \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).