qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Lukáš Doktor" <ldoktor@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Performance improvement with 81f730d4
Date: Wed, 19 Apr 2023 08:02:28 +0200	[thread overview]
Message-ID: <f8f0c9ff-5cb9-a440-f84f-19d55f7036a8@redhat.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 559 bytes --]

Hello Paolo,

the perf-ci detected and bisected the 81f730d4 - block, block-backend: write some hot coroutine wrappers by hand - as a performance improvement with 4K read/writes across various profiles. Without pinning it was about 10%, with pinned qemu about 15%.

    https://ldoktor.github.io/tmp/RedHat-virtlab722/v8.0.0/130-improvement.html

Based on the commit message I guess it's expected, so my question is whether I should report such obvious improvements or only report improvements/regressions that are not that obvious?

Regards,
Lukáš

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 12925 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

             reply	other threads:[~2023-04-19  6:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  6:02 Lukáš Doktor [this message]
2023-04-19  8:16 ` Performance improvement with 81f730d4 Kevin Wolf
2023-04-19 13:01   ` Lukáš Doktor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8f0c9ff-5cb9-a440-f84f-19d55f7036a8@redhat.com \
    --to=ldoktor@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).