From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvQge-0006no-D6 for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvQgc-0001xy-Hm for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:57:08 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:36754) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvQgc-0001wt-7q for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:57:06 -0500 Received: by mail-pg1-x541.google.com with SMTP id r124so7273372pgr.3 for ; Sun, 17 Feb 2019 09:57:06 -0800 (PST) References: <20190214125107.22178-1-peter.maydell@linaro.org> <20190214125107.22178-6-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Sun, 17 Feb 2019 09:57:00 -0800 MIME-Version: 1.0 In-Reply-To: <20190214125107.22178-6-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org On 2/14/19 4:50 AM, Peter Maydell wrote: > Create a new include file for the pl011's device struct, > type macros, etc, so that it can be instantiated using > the "embedded struct" coding style. > > Signed-off-by: Peter Maydell > --- > include/hw/char/pl011.h | 34 ++++++++++++++++++++++++++++++++++ > hw/char/pl011.c | 31 ++----------------------------- > 2 files changed, 36 insertions(+), 29 deletions(-) Reviewed-by: Richard Henderson r~