From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Claudio Fontana <cfontana@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] softmmu: Add missing trace-events file
Date: Thu, 6 Aug 2020 17:10:02 +0200 [thread overview]
Message-ID: <f92dea77-90a3-d08e-3b9b-eb7c32bd04fa@redhat.com> (raw)
In-Reply-To: <4816dcc4-2fa2-75a7-6164-e4b0b0ffa723@suse.de>
On 8/6/20 4:24 PM, Claudio Fontana wrote:
> On 8/6/20 4:21 PM, Paolo Bonzini wrote:
>> On 05/08/20 15:27, Markus Armbruster wrote:
>>>> Commit c7f419f584 moved softmmu-only files out of the root
>>>> directory, but forgot to move the trace events, which should
>>>> no longer be generated to "trace-root.h". Fix that by adding
>>>> softmmu/trace-events.
>>> Dang! I'd like to have this in 5.1 if at all possible.
>>>
>>
>> Does this matter at all for usage of tracepoints?
Markus said on IRC it is a false alarm, can wait 5.2 :)
>>
>> Paolo
>>
>>
>
> Hi Paolo, I tested both with and without the fix,
> the events seem to be generated anyway.
>
> Using simple trace backend, simple smoke test tracing the memory_region_ops_read from softmmu/memory.c
>
> Thanks,
>
> Claudio
>
next prev parent reply other threads:[~2020-08-06 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 13:02 [PATCH] softmmu: Add missing trace-events file Philippe Mathieu-Daudé
2020-08-05 13:27 ` Markus Armbruster
2020-08-05 13:57 ` Philippe Mathieu-Daudé
2020-08-06 14:16 ` Markus Armbruster
2020-08-06 14:21 ` Paolo Bonzini
2020-08-06 14:24 ` Claudio Fontana
2020-08-06 15:10 ` Philippe Mathieu-Daudé [this message]
2020-08-06 15:10 ` Markus Armbruster
2020-08-05 13:53 ` Claudio Fontana
2020-08-12 19:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92dea77-90a3-d08e-3b9b-eb7c32bd04fa@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=david@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).