From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCpfG-0004xp-KU for qemu-devel@nongnu.org; Tue, 14 Jun 2016 10:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCpfE-0001WJ-6U for qemu-devel@nongnu.org; Tue, 14 Jun 2016 10:50:01 -0400 References: <1463550807-2750-1-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: Date: Tue, 14 Jun 2016 16:49:53 +0200 MIME-Version: 1.0 In-Reply-To: <1463550807-2750-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0jES0UArWNm5drB0iqfpUbOPLkoMJxbR0" Subject: Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Jeff Cody , Kevin Wolf , qemu-block@nongnu.org, jsnow@redhat.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0jES0UArWNm5drB0iqfpUbOPLkoMJxbR0 From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Jeff Cody , Kevin Wolf , qemu-block@nongnu.org, jsnow@redhat.com, qemu-stable@nongnu.org Message-ID: Subject: Re: [PATCH] backup: Fail early if cannot determine cluster size References: <1463550807-2750-1-git-send-email-famz@redhat.com> In-Reply-To: <1463550807-2750-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.05.2016 07:53, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. >=20 > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Fam Zheng > --- > block/backup.c | 34 ++++++++++++++++++---------------- > 1 file changed, 18 insertions(+), 16 deletions(-) Sorry for having waited so long (I was thinking that maybe Jeff wanted to take this patch), but now the patch no longer applies and I don't feel comfortable with just fixing it up myself; git-backport-diff tells me the required changes are "[0015] [FC]". Max --0jES0UArWNm5drB0iqfpUbOPLkoMJxbR0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXYBmRAAoJEDuxQgLoOKytwmEH/ApY0Ms7X+GPp4sVSU1eFAdt dg7ryRxeIV/IICSK3HpkFwAgUlFM+n4PZdK2oK5F/tRMNCLepRpCsJtYtaH1jjsX Sl9wuQpDQRsS0iYgsdYbLIYsZgXzDFhH55G81TunkingM9Dx9pdHdpeqTjBCyPBp XKxS7LZcP8suCy3P0sMQLsfQTqD05YhZhYrV0xjrPK6m+HCrax1ep8CR6Hc65HaY 0wXtUbXRd5RBMeMbsjUVxhsz6q9b346EtnziIgUWVZvzoF5Nk8WxPLUauQtYQ5br TUvz6Euwo5lakdPdC4QLvGsV/YDk1O8GjiyNuo7poTqxXNMlx4LmzAR9sLlwLHs= =/Ayd -----END PGP SIGNATURE----- --0jES0UArWNm5drB0iqfpUbOPLkoMJxbR0--