From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] crypto: fix error check on gcry_md_open
Date: Wed, 30 Oct 2024 15:56:07 -0300 [thread overview]
Message-ID: <f938ec8e-b47b-47aa-94bd-fe263eb2da32@linaro.org> (raw)
In-Reply-To: <20241030101150.3023300-2-berrange@redhat.com>
On 30/10/24 07:11, Daniel P. Berrangé wrote:
> Gcrypt does not return negative values on error, it returns non-zero
> values. This caused QEMU not to detect failure to open an unsupported
> hash, resulting in a later crash trying to use a NULL context.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> crypto/hash-gcrypt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-10-30 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 10:11 [PATCH 0/2] crypto: misc gcrypt hash/hmac fixes Daniel P. Berrangé
2024-10-30 10:11 ` [PATCH 1/2] crypto: fix error check on gcry_md_open Daniel P. Berrangé
2024-10-30 18:56 ` Philippe Mathieu-Daudé [this message]
2024-10-30 10:11 ` [PATCH 2/2] crypto: perform runtime check for hash/hmac support in gcrypt Daniel P. Berrangé
2024-10-31 4:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f938ec8e-b47b-47aa-94bd-fe263eb2da32@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).