From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: fix resource leaks in gen-vdso
Date: Thu, 20 Mar 2025 16:16:30 -0700 [thread overview]
Message-ID: <f95a49d5-4fd1-4c6a-85ff-1b5bacd1f0bd@linaro.org> (raw)
In-Reply-To: <20250219100336.1696758-1-berrange@redhat.com>
On 2/19/25 02:03, Daniel P. Berrangé wrote:
> + cleanup:
> + free(buf);
> +
> + if (outf &&
> + fclose(outf) != 0)
> + ret = EXIT_FAILURE;
> + if (inf &&
> + fclose(inf) != 0)
> + ret = EXIT_FAILURE;
> + return ret;
Modulo the lack of braces here, the patch looks fine.
r~
prev parent reply other threads:[~2025-03-20 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 10:03 [PATCH] linux-user: fix resource leaks in gen-vdso Daniel P. Berrangé
2025-03-20 17:38 ` Daniel P. Berrangé
2025-03-20 23:16 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f95a49d5-4fd1-4c6a-85ff-1b5bacd1f0bd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).