From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>,
Alistair Francis <alistair23@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
Alistair.Francis@wdc.com, palmer@dabbelt.com,
bin.meng@windriver.com, sergey.matyukevich@syntacore.com,
vladimir.isaev@syntacore.com, anatoly.parshintsev@syntacore.com,
philipp.tomsich@vrull.eu, zhiwei_liu@c-sky.com
Subject: Re: [PATCH v1 4/4] target/riscv: Add itrigger_enabled field to CPURISCVState
Date: Thu, 10 Nov 2022 16:35:07 +1100 [thread overview]
Message-ID: <f9600317-b40a-50fc-3f85-8ccae0c6790e@linaro.org> (raw)
In-Reply-To: <4fb639df-889f-a76d-6c62-126ec4d9e5e1@linux.alibaba.com>
On 11/10/22 13:15, LIU Zhiwei wrote:
>>> +static int debug_post_load(void *opaque, int version_id)
>>> +{
>>> + RISCVCPU *cpu = opaque;
>>> + CPURISCVState *env = &cpu->env;
>>> +
>>> + if (icount_enabled()) {
>>> + env->itrigger_enabled = riscv_itrigger_enabled(env);
>>> + }
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static const VMStateDescription vmstate_debug = {
>>> .name = "cpu/debug",
>>> .version_id = 2,
>>> .minimum_version_id = 2,
>> The versions here should be bumped
>
> Hi Alistair and Richard,
>
> I am not sure if we should bump versions when just add post_load callback without adding
> new fields. I once upstreamed a patch
> with a similar change but not bumping version.
Simply adding a post_load does not require a version bump.
r~
next prev parent reply other threads:[~2022-11-10 5:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 6:29 [PATCH v1 0/4] Support native debug icount trigger LIU Zhiwei
2022-10-13 6:29 ` [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled LIU Zhiwei
2022-11-07 1:37 ` Alistair Francis
2022-11-07 2:01 ` LIU Zhiwei
2022-11-07 15:58 ` Alex Bennée
2022-11-08 1:54 ` LIU Zhiwei
2022-11-09 22:33 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 2/4] target/riscv: Add itrigger support when icount is enabled LIU Zhiwei
2022-11-09 22:50 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 3/4] target/riscv: Enable native debug itrigger LIU Zhiwei
2022-11-09 22:54 ` Alistair Francis
2022-10-13 6:29 ` [PATCH v1 4/4] target/riscv: Add itrigger_enabled field to CPURISCVState LIU Zhiwei
2022-11-09 22:55 ` Alistair Francis
2022-11-10 2:15 ` LIU Zhiwei
2022-11-10 5:35 ` Richard Henderson [this message]
2022-11-11 0:54 ` Alistair Francis
2022-11-11 5:31 ` [PATCH v1 0/4] Support native debug icount trigger Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9600317-b40a-50fc-3f85-8ccae0c6790e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=anatoly.parshintsev@syntacore.com \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sergey.matyukevich@syntacore.com \
--cc=vladimir.isaev@syntacore.com \
--cc=zhiwei_liu@c-sky.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).