From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Taylor Simpson <tsimpson@quicinc.com>,
Sergio Lopez <slp@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup
Date: Tue, 30 Nov 2021 09:40:49 +0100 [thread overview]
Message-ID: <f9620df1-f67e-a5d2-579c-5f9010c6b531@linaro.org> (raw)
In-Reply-To: <20211129200510.1233037-1-peter.maydell@linaro.org>
On 11/29/21 9:05 PM, Peter Maydell wrote:
> qemu-common.h has a comment at the top:
>
> * This file is supposed to be included only by .c files. No header file should
> * depend on qemu-common.h, as this would easily lead to circular header
> * dependencies.
>
> We still have a few .h files which include it, though. The first 3
> patches in this series fix that: in 3 out of 4 cases we didn't need
> the #include at all, and in the 4th case we can instead #include
> qemu-common.h from just one .c file.
>
> Patch 4 is just removing the #include from 8 files in hw/arm which
> don't need it at all. (Probably there are other files like this, but
> I just did the Arm related ones.)
>
> Tested by pushing to gitlab for the CI build.
>
> -- PMM
>
> Peter Maydell (4):
> include/hw/i386: Don't include qemu-common.h in .h files
> target/hexagon/cpu.h: don't include qemu-common.h
> target/rx/cpu.h: Don't include qemu-common.h
> hw/arm: Don't include qemu-common.h unnecessarily
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-11-30 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:05 [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h Peter Maydell
2021-12-07 16:55 ` Taylor Simpson
2021-11-29 20:05 ` [PATCH for-7.0 3/4] target/rx/cpu.h: Don't " Peter Maydell
2021-12-01 12:26 ` Yoshinori Sato
2021-11-29 20:05 ` [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily Peter Maydell
2021-11-29 20:48 ` [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-30 10:02 ` Markus Armbruster
2021-11-30 8:40 ` Richard Henderson [this message]
2021-12-01 13:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9620df1-f67e-a5d2-579c-5f9010c6b531@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=tsimpson@quicinc.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).