From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F86EC433E0 for ; Mon, 15 Mar 2021 13:49:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D56A64E10 for ; Mon, 15 Mar 2021 13:49:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D56A64E10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLnag-0000Ji-DR for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 09:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLnZV-0008C8-Rg for qemu-devel@nongnu.org; Mon, 15 Mar 2021 09:47:50 -0400 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]:36789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLnZM-0007k4-IV for qemu-devel@nongnu.org; Mon, 15 Mar 2021 09:47:49 -0400 Received: by mail-qt1-x82e.google.com with SMTP id h7so2277652qtx.3 for ; Mon, 15 Mar 2021 06:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hmk1nMsV3L3wctRV91RXdfvPQU++522J8XtUSgdT1mw=; b=jYPJQM0Zqlpb5vGk5MdJDXFgqX2s4kBsoRv+sJExAA+LodNRbtsgUN32kawgIlA9wT nfxaqORJg4MxzjDSy0z6efZ2MPsNsyxNBGFdQctwPK8EzKf8l2ki5Vg8RceOtuGI+gva gsTIKGvl054MBLgbngGa/xt4z/y1/jp6ZvtlsJvxCmQWdIWw0HN+baDDLJvjVdAwiW+w BW3xgP22jNLmTe6HHqDjo/N/wRGJ6+sPfd/plcE6qUI+c785t+iixEHdfcZu2akXXE+Z Zx0Ti8Ri23a9iQE6/Pniljjeow5jqhvRBBoY2td43iOXF1dOOhL2e8JPZPOrhONwJPLz BAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hmk1nMsV3L3wctRV91RXdfvPQU++522J8XtUSgdT1mw=; b=JQpT8Pj7tYJ/telYXqeIvYALjeSwyORhny4JZ1Pm0iHQJp0MJaRBfS6Fp0YjxVhSbO aC94AOaZUviwj2DwHSZgUYewWKd2Dw9Dxx390/ZJyY8buzbErfGyvqG4oEums5Gtc5TN MV+9Y458PD4WLlIfYRxnl0R7dsrw8SB42Bx5D4i0GWuxOaSGkdebHowRuXdmrGJrcRbM 3CHcWy3G0dFzf7ZgLqLXMioW+oHcTkzJ3cbNxC6t0acl4zUo7WRcoHJKG5wi1aPNrvqm jONxC4+AVNlkxDq8XZiRqLzfwA/FxolYyTng55rCM2ZrDxFxlsr91AmR/zESeKFENsR6 3uUQ== X-Gm-Message-State: AOAM533rRkT1l3hOTX3svmm5Y0gN8ro17nPxTigrx4/NDoVPhaRFpTze jRTSYQAiWVGp6HQTOIxLmyTg5A== X-Google-Smtp-Source: ABdhPJwD66T+G10gRZwX8YotO3pVnDWZN4iAuFHF5lMnx1tucqD4PI4iGahG+Jao5zxYYniJZtFlZQ== X-Received: by 2002:ac8:5e89:: with SMTP id r9mr22813713qtx.10.1615816058183; Mon, 15 Mar 2021 06:47:38 -0700 (PDT) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id c19sm12426817qkl.78.2021.03.15.06.47.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 06:47:37 -0700 (PDT) Subject: Re: [PATCH v3 14/16] hw/ppc: Use hreg_store_msr for msr updates To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-devel@nongnu.org References: <20210314175906.1733746-1-richard.henderson@linaro.org> <20210314175906.1733746-15-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Mon, 15 Mar 2021 07:47:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82e; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivan@vmfacility.fr, qemu-ppc@nongnu.org, Greg Kurz , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/15/21 4:23 AM, Cédric Le Goater wrote: > On 3/14/21 6:59 PM, Richard Henderson wrote: >> Only one of the three places in hw/ppc that modify msr updated >> hflags. Even in that case, use the official interface instead >> of a direct call to hreg_compute_hflags. > > ppc_store_msr() is the interface to use. > >> Signed-off-by: Richard Henderson >> --- >> Cc: Cédric Le Goater >> Cc: Greg Kurz >> --- >> hw/ppc/pnv_core.c | 3 ++- >> hw/ppc/spapr_hcall.c | 3 +-- >> hw/ppc/spapr_rtas.c | 3 ++- >> 3 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c >> index bd2bf2e044..31f041b9c7 100644 >> --- a/hw/ppc/pnv_core.c >> +++ b/hw/ppc/pnv_core.c >> @@ -29,6 +29,7 @@ >> #include "hw/ppc/pnv_xscom.h" >> #include "hw/ppc/xics.h" >> #include "hw/qdev-properties.h" >> +#include "helper_regs.h" >> >> static const char *pnv_core_cpu_typename(PnvCore *pc) >> { >> @@ -54,7 +55,7 @@ static void pnv_core_cpu_reset(PnvCore *pc, PowerPCCPU *cpu) >> */ >> env->gpr[3] = PNV_FDT_ADDR; >> env->nip = 0x10; >> - env->msr |= MSR_HVB; /* Hypervisor mode */ >> + hreg_store_msr(env, env->msr | MSR_HVB, true); /* Hypervisor mode */ > > > This is going to have the opposite effect of not setting the HV bit in the > PowerNV machine. See the comment in powerpc_set_excp_state(). > > May be commit 1c953ba57ada ("ppc: Fix hreg_store_msr() so that non-HV > mode cannot alter MSR:HV") needs a fix first. Hmm. I mis-read the code and assumed "allow_hv" allowed hv to be changed. There must be some kind of quirkyness here that I don't understand. I'll just have these reset functions use hreg_recompute_hflags directly. r~