From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80A3C433DB for ; Mon, 8 Mar 2021 11:58:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 242BF64D92 for ; Mon, 8 Mar 2021 11:58:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 242BF64D92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJEXH-0005UB-48 for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 06:58:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJEVj-00043O-RU for qemu-devel@nongnu.org; Mon, 08 Mar 2021 06:57:19 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:36773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJEVi-0003pv-FR for qemu-devel@nongnu.org; Mon, 08 Mar 2021 06:57:19 -0500 Received: by mail-ed1-x531.google.com with SMTP id l12so14337227edt.3 for ; Mon, 08 Mar 2021 03:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v8xfz3K5IP3moSWfOYtuYGN0mGRfWAooo7wRwIW9KQE=; b=JSBTnH5EU5Ql9XI67wveAj87FKLOFcOW6vV7MB+q/YYSA21NETSEepLdaZPbQgrDRR FTIKTJRDd4/TkKb+MM4Jbf9nh52ZGJVuJAE8vadtvdAcA9Ax1DofCIAeCbuOfbgs+lxR vstDFan1l0nGjgsQnoc1qU9fz7eorQ6gSz7MzxUcDiB8Lj5ym6GCGVAUfW749kkmFigJ buP23ZWkjtJhdB6fR6QRSdrmlaxoMx6N970mSFNceRuvZSZECS3i1Oe8+zgfW5LAaEih 3zdQaVEutqXAT34cAbXsypAGJNBEsHtC8gaA70CKyocR+OntPcuMj5ru4PPUGB80NL04 f/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v8xfz3K5IP3moSWfOYtuYGN0mGRfWAooo7wRwIW9KQE=; b=R32UgcY0h6gDDq3omZyHNoyi8wLOyhYIA96cMyM39i7aaeeJqJDj6tF5IfASewIRQ+ 148ywR2vjtBnyHJZ6mKwhVuFu6AznUJ6qfQmSHRZ9vjvsfUXhS/EqNQL4LxTH+Ljs/dB kySdtRXhixDqIqXJ/Mm3S4EwYKufjFeAt6u3CZE4jkDZ85PBVQrmAEcOM7bZTjPM/UMh TlWZXtTOmBD84V/CafgESCYrCI1sCYiEQzp+5ySr3Q0JdJ862JnGHnMYkJSsfDY4ZqOR tIs77kI8PAIALkB95qW9RY53EkhBDqLk0tpP65wFjDxiw4h9kQzh/7AYkr9LA/4hEeOO Jwxw== X-Gm-Message-State: AOAM531q5Zvop/9lBR4YUOd4y9Y0Njvmfvm68YqcgIF3EGH3ojb4kEzp DYguvNRJ7nKxG40hWyI56iseslVU3Xg= X-Google-Smtp-Source: ABdhPJyQQEkiJPzWd7U52U5z3ggWfpl+ec3CiQTA58FPRDvxKQzqNjesmete7E9WqTdsMorDQO7vhw== X-Received: by 2002:aa7:c441:: with SMTP id n1mr20969405edr.203.1615204637061; Mon, 08 Mar 2021 03:57:17 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id b21sm6550922ejv.13.2021.03.08.03.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 03:57:16 -0800 (PST) Subject: Re: [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Richard Henderson , qemu-devel@nongnu.org References: <20210214175912.732946-1-f4bug@amsat.org> <20210214175912.732946-12-f4bug@amsat.org> Message-ID: Date: Mon, 8 Mar 2021 12:57:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Fredrik Noring , Aleksandar Rikalo , Laurent Vivier , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Aurelien Jarno , "Maciej W. Rozycki" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 11:48 AM, Philippe Mathieu-Daudé wrote: > On 2/15/21 5:26 PM, Richard Henderson wrote: >> On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >>> + if (a->rt == 0) { >>> + tcg_gen_movi_i64(cpu_gpr[a->rd], 0); >>> + tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); >>> + return true; >>> + } >> >> Is there a good reason not to use gen_load_gpr? > > I suppose you meant gen_store_gpr*(). Double checking, we check for $rt, not $rd, right? > > We need to check $rt anyway to not do the deposit calls > if it is non-zero. > > As it is mostly code movement, I prefer to keep it as it > for now, we might improve it later. > >> >> Otherwise, >> Reviewed-by: Richard Henderson > > Thanks! >