From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH] os: deprecate the -enable-fips option and QEMU's FIPS enforcement
Date: Tue, 20 Oct 2020 19:22:03 +0200 [thread overview]
Message-ID: <f97dc04a-0cc4-3ba0-ea5e-b185cd0958a7@redhat.com> (raw)
In-Reply-To: <20201020162211.401204-1-berrange@redhat.com>
On 20/10/20 18:22, Daniel P. Berrangé wrote:
> @@ -153,6 +153,9 @@ int os_parse_cmd_args(int index, const char *optarg)
> break;
> #if defined(CONFIG_LINUX)
> case QEMU_OPTION_enablefips:
> + warn_report("-enable-fips is deprecated, please build QEMU with "
> + "the `libgcrypt` library as the cryptography provider "
> + "to enable FIPS compliance");
> fips_set_state(true);
> break;
> #endif
Should you also remove fips_set_state(true) and make fips_get_state()
return the contents of /proc/sys/crypto/fips_enabled, so that VNC
password authentication is disabled?
Paolo
next prev parent reply other threads:[~2020-10-20 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 16:22 [PATCH] os: deprecate the -enable-fips option and QEMU's FIPS enforcement Daniel P. Berrangé
2020-10-20 17:22 ` Paolo Bonzini [this message]
2020-10-21 8:38 ` Daniel P. Berrangé
2020-10-21 9:51 ` Paolo Bonzini
2020-10-21 10:17 ` Daniel P. Berrangé
2020-10-21 11:47 ` Paolo Bonzini
2020-10-22 14:04 ` John Snow
2020-10-21 5:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97dc04a-0cc4-3ba0-ea5e-b185cd0958a7@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).