From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com,
mnestratov@virtuozzo.com, mreitz@redhat.com,
nshirokovskiy@virtuozzo.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable
Date: Mon, 22 Jan 2018 14:56:46 -0500 [thread overview]
Message-ID: <f99445cc-4f70-ca06-4831-b042c1dd30d7@redhat.com> (raw)
In-Reply-To: <b6e71cfa-19f6-8b98-4e6a-a5d230129f62@redhat.com>
On 01/22/2018 02:51 PM, Eric Blake wrote:
> On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote:
>
>>>>
>>> I have to admit exposing this interface still makes me nervous, but :)
>>>
>>> Mechanically correct, and with suggesting phrasing changes:
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>
> Should we go with an x- prefix for now, and let things settle for a
> release before promoting it to fully supported, just in case we find
> something that justifies your nervousness in accepting the interface?
>
I proposed as much in a reply to the cover letter; I'm willing to take
patch one now for the sake of migration; the rest of this series I want
a test suite that helps document the anticipated use case, or otherwise
an x- prefix for the command names.
next prev parent reply other threads:[~2018-01-22 19:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 12:54 [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API Vladimir Sementsov-Ogievskiy
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 1/6] block: maintain persistent disabled bitmaps Vladimir Sementsov-Ogievskiy
2018-01-19 23:43 ` John Snow
2018-01-22 9:08 ` Vladimir Sementsov-Ogievskiy
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-01-19 23:45 ` John Snow
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable Vladimir Sementsov-Ogievskiy
2018-01-19 23:50 ` John Snow
2018-01-22 9:09 ` Vladimir Sementsov-Ogievskiy
2018-01-22 19:51 ` Eric Blake
2018-01-22 19:56 ` John Snow [this message]
2018-02-02 15:37 ` Vladimir Sementsov-Ogievskiy
2018-02-03 16:09 ` Markus Armbruster
2018-02-05 11:59 ` Vladimir Sementsov-Ogievskiy
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 4/6] qmp: transaction support for block-dirty-bitmap-enable/disable Vladimir Sementsov-Ogievskiy
2018-01-17 15:06 ` Vladimir Sementsov-Ogievskiy
2018-01-20 0:28 ` John Snow
2018-01-22 9:14 ` Vladimir Sementsov-Ogievskiy
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 5/6] qapi: add block-dirty-bitmap-merge Vladimir Sementsov-Ogievskiy
2018-02-03 16:06 ` Markus Armbruster
2018-02-05 12:00 ` Vladimir Sementsov-Ogievskiy
[not found] ` <66a8f977-9274-e77b-e795-21a50690c4eb@redhat.com>
2018-10-08 13:24 ` Vladimir Sementsov-Ogievskiy
2018-01-16 12:54 ` [Qemu-devel] [PATCH v2 6/6] qapi: add disabled parameter to block-dirty-bitmap-add Vladimir Sementsov-Ogievskiy
2018-01-19 23:30 ` [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API John Snow
2018-01-22 9:20 ` Vladimir Sementsov-Ogievskiy
2018-01-22 12:22 ` Vladimir Sementsov-Ogievskiy
2018-01-22 17:23 ` John Snow
2018-02-02 11:56 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99445cc-4f70-ca06-4831-b042c1dd30d7@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mnestratov@virtuozzo.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).