From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, programmingkidx@gmail.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] test-qga: Avoid qobject_from_jsonf("%"PRId64)
Date: Wed, 23 Nov 2016 13:06:18 +0100 [thread overview]
Message-ID: <f9a1182d-d86c-9072-0f52-d2f560e87579@redhat.com> (raw)
In-Reply-To: <21053836-664b-d6a2-d324-bf9b942e3a15@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On 23/11/2016 11:36, Eric Blake wrote:
> This is the key, look at:
> $ git grep -A2 strdup_printf tests/test-qga.c
>
> and you'll see that my change is no grosser than the rest of the file.
>
Oh well... I guess with a better commit message the patch is fine.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-11-23 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:16 [Qemu-devel] [PATCH for-2.8 0/3] Fix MacOS runtime failure of qobject_from_jsonf() Eric Blake
2016-11-23 4:16 ` [Qemu-devel] [PATCH 1/3] qmp-event: Avoid qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 13:45 ` Markus Armbruster
2016-11-23 13:56 ` Eric Blake
2016-11-23 14:04 ` Eric Blake
2016-11-23 4:16 ` [Qemu-devel] [PATCH 2/3] test-qga: " Eric Blake
2016-11-23 9:23 ` Paolo Bonzini
2016-11-23 10:36 ` Eric Blake
2016-11-23 11:08 ` Eric Blake
2016-11-23 12:06 ` Paolo Bonzini [this message]
2016-11-23 14:05 ` Markus Armbruster
2016-11-23 14:14 ` Eric Blake
2016-11-23 16:55 ` Markus Armbruster
2016-11-23 4:16 ` [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64) Eric Blake
2016-11-23 9:25 ` Paolo Bonzini
2016-11-23 10:54 ` Eric Blake
2016-11-23 14:17 ` Markus Armbruster
2016-11-23 14:24 ` Eric Blake
2016-11-23 16:56 ` Markus Armbruster
2016-11-23 16:59 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a1182d-d86c-9072-0f52-d2f560e87579@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).