From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug
Date: Mon, 21 Mar 2011 18:39:21 +0530 [thread overview]
Message-ID: <f9a90f189c780e066039f2de3906c73c48071bb7.1300712809.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1300712809.git.amit.shah@redhat.com>
In-Reply-To: <cover.1300712809.git.amit.shah@redhat.com>
After a hot-unplug operation, the previous behaviour was to close the
chardev. That meant the chardev couldn't be re-used. Also, since
chardev hot-plug isn't possible so far, this means virtio-console
hot-plug isn't feasible as well.
With this change, the chardev is kept around. A new virtio-console
channel can then be hot-plugged with the same chardev and things will
continue to work.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-console.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index be59558..6b5237b 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -82,7 +82,11 @@ static int virtconsole_exitfn(VirtIOSerialPort *port)
VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
if (vcon->chr) {
- qemu_chr_close(vcon->chr);
+ /*
+ * Instead of closing the chardev, free it so it can be used
+ * for other purposes.
+ */
+ qemu_chr_add_handlers(vcon->chr, NULL, NULL, NULL, NULL);
}
return 0;
--
1.7.4
next prev parent reply other threads:[~2011-03-21 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 13:09 [Qemu-devel] [PULL #7 0/7] virtio-serial fixes, enhancements Amit Shah
2011-03-21 13:09 ` [Qemu-devel] [PATCH 1/7] virtio-serial: Use a struct to pass config information from proxy Amit Shah
2011-03-23 13:26 ` [Qemu-devel] " Juan Quintela
2011-03-21 13:09 ` [Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0 Amit Shah
2011-03-21 13:09 ` [Qemu-devel] [PATCH 3/7] virtio-serial: Enable ioeventfd Amit Shah
2011-03-21 13:09 ` [Qemu-devel] [PATCH 4/7] virtio-serial-bus: Simplify handle_output() function Amit Shah
2011-03-21 13:09 ` [Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear ->have_data() pointer after unplug Amit Shah
2011-03-23 13:33 ` [Qemu-devel] " Juan Quintela
2011-03-23 13:39 ` Amit Shah
2011-03-21 13:09 ` Amit Shah [this message]
2011-03-21 13:09 ` [Qemu-devel] [PATCH 7/7] char: Prevent multiple devices opening same chardev Amit Shah
2011-03-23 13:32 ` [Qemu-devel] " Juan Quintela
2011-03-23 13:31 ` [Qemu-devel] Re: [PULL #7 0/7] virtio-serial fixes, enhancements Juan Quintela
2011-03-23 13:40 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a90f189c780e066039f2de3906c73c48071bb7.1300712809.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).