From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40670 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1erj-0005E8-1b for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1erh-0007QJ-5Z for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1erg-0007QD-TR for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:45 -0400 From: Amit Shah Date: Mon, 21 Mar 2011 18:39:21 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu list After a hot-unplug operation, the previous behaviour was to close the chardev. That meant the chardev couldn't be re-used. Also, since chardev hot-plug isn't possible so far, this means virtio-console hot-plug isn't feasible as well. With this change, the chardev is kept around. A new virtio-console channel can then be hot-plugged with the same chardev and things will continue to work. Signed-off-by: Amit Shah --- hw/virtio-console.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index be59558..6b5237b 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -82,7 +82,11 @@ static int virtconsole_exitfn(VirtIOSerialPort *port) VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); if (vcon->chr) { - qemu_chr_close(vcon->chr); + /* + * Instead of closing the chardev, free it so it can be used + * for other purposes. + */ + qemu_chr_add_handlers(vcon->chr, NULL, NULL, NULL, NULL); } return 0; -- 1.7.4