From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43427 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pq0ag-0006B4-CM for qemu-devel@nongnu.org; Thu, 17 Feb 2011 04:56:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pq0af-0001Vf-8z for qemu-devel@nongnu.org; Thu, 17 Feb 2011 04:56:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pq0ae-0001VW-Rr for qemu-devel@nongnu.org; Thu, 17 Feb 2011 04:56:01 -0500 From: Amit Shah Date: Thu, 17 Feb 2011 14:43:24 +0530 Message-Id: Subject: [Qemu-devel] [PATCH] virtio-serial: Enable ioeventfd List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah Enable ioeventfd for virtio-serial devices by default. Commit 25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using ioeventfd. Copying a file from guest to host over a virtio-serial channel didn't show much difference in time or io_exit rate. Signed-off-by: Amit Shah --- hw/virtio-pci.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 3911b09..d7fdaee 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -789,6 +789,7 @@ static int virtio_serial_exit_pci(PCIDevice *pci_dev) { VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev); + virtio_pci_stop_ioeventfd(proxy); virtio_serial_exit(proxy->vdev); return virtio_exit_pci(pci_dev); } @@ -898,6 +899,8 @@ static PCIDeviceInfo virtio_info[] = { .init = virtio_serial_init_pci, .exit = virtio_serial_exit_pci, .qdev.props = (Property[]) { + DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, + VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true), DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, DEV_NVECTORS_UNSPECIFIED), DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0), -- 1.7.4