From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Taylor Simpson <tsimpson@quicinc.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user/hexagon: Use generic target_stat64 structure
Date: Wed, 17 Nov 2021 08:17:53 +0100 [thread overview]
Message-ID: <f9c0e14e-6aee-06ea-dc5a-3e96e29bb2f6@linaro.org> (raw)
In-Reply-To: <20211116210919.2823206-1-f4bug@amsat.org>
On 11/16/21 10:09 PM, Philippe Mathieu-Daudé wrote:
> Linux Hexagon port doesn't define a specific 'struct stat'
> but uses the generic one (see Linux commit 6103ec56c65c [*]
> "asm-generic: add generic ABI headers" which predates the
> introduction of the Hexagon port).
>
> Remove the target specific target_stat (which in fact is the
> target_stat64 structure but uses incorrect target_long and
> ABI unsafe long long types) and use the generic target_stat64
> instead.
>
> [*]https://github.com/torvalds/linux/commit/6103ec56c65c3#diff-5f59b07b38273b7d6a74193bc81a8cd18928c688276eae20cb10c569de3253ee
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> linux-user/syscall_defs.h | 28 ++--------------------------
> 1 file changed, 2 insertions(+), 26 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-11-17 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 21:09 [PATCH] linux-user/hexagon: Use generic target_stat64 structure Philippe Mathieu-Daudé
2021-11-17 7:17 ` Richard Henderson [this message]
2021-11-17 8:23 ` Taylor Simpson
2021-12-06 14:21 ` Philippe Mathieu-Daudé
2021-12-06 14:26 ` Philippe Mathieu-Daudé
2021-12-15 10:36 ` Philippe Mathieu-Daudé
2021-12-15 14:59 ` Taylor Simpson
2021-12-19 16:04 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c0e14e-6aee-06ea-dc5a-3e96e29bb2f6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).