From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v5 4/4] accel/tcg: Move perf and debuginfo support to tcg
Date: Thu, 25 Jan 2024 05:53:48 +0100 [thread overview]
Message-ID: <f9cf4786-45d8-49d7-a7d8-44d177a11bf0@linaro.org> (raw)
In-Reply-To: <3e32f06d1f4b35c3b5c67434593f466995a38c87.camel@linux.ibm.com>
On 25/1/24 04:04, Ilya Leoshkevich wrote:
> On Thu, 2024-01-25 at 07:11 +1000, Richard Henderson wrote:
>> On 1/24/24 17:56, Philippe Mathieu-Daudé wrote:
>>> From: Ilya Leoshkevich <iii@linux.ibm.com>
>>>
>>> tcg/ should not depend on accel/tcg/, but perf and debuginfo
>>> support provided by the latter are being used by tcg/tcg.c.
>>>
>>> Since that's the only user, move both to tcg/.
>>>
>>> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
>>> Message-ID: <20231208003754.3688038-5-iii@linux.ibm.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>> {accel/tcg => tcg}/debuginfo.h | 4 ++--
>>> {accel/tcg => tcg}/perf.h | 4 ++--
>>
>> Headers should be in include/tcg/.
>>
>>> --- a/accel/tcg/translate-all.c
>>> +++ b/accel/tcg/translate-all.c
>>> @@ -63,7 +63,7 @@
>>> #include "tb-context.h"
>>> #include "internal-common.h"
>>> #include "internal-target.h"
>>> -#include "perf.h"
>>> +#include "tcg/perf.h"
>>
>> Since it is used from accel/tcg/,
>>
>>> #include "tcg/insn-start-words.h"
>>>
>>> TBContext tb_ctx;
>>> diff --git a/hw/core/loader.c b/hw/core/loader.c
>>> index e7a9b3775b..b8e52f3fb0 100644
>>> --- a/hw/core/loader.c
>>> +++ b/hw/core/loader.c
>>> @@ -62,7 +62,7 @@
>>> #include "hw/boards.h"
>>> #include "qemu/cutils.h"
>>> #include "sysemu/runstate.h"
>>> -#include "accel/tcg/debuginfo.h"
>>> +#include "tcg/debuginfo.h"
>>
>> ... and hw/core/.
>>
>> Otherwise,
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> r~
>
> Can it be that this is the rebased v3?
> v4 seems to have these issues fixed:
>
> https://patchew.org/QEMU/20231212003837.64090-1-iii@linux.ibm.com/
Indeed 🤦♂️ v6 on the way...
prev parent reply other threads:[~2024-01-25 4:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 7:56 [PATCH v5 0/4] accel/tcg: Move perf and debuginfo support to tcg Philippe Mathieu-Daudé
2024-01-24 7:56 ` [PATCH v5 1/4] target: Make qemu_target_page_mask() available for *-user Philippe Mathieu-Daudé
2024-01-24 21:06 ` Richard Henderson
2024-01-24 7:56 ` [PATCH v5 2/4] tcg: Make tb_cflags() usable from target-agnostic code Philippe Mathieu-Daudé
2024-01-24 21:07 ` Richard Henderson
2024-01-24 7:56 ` [PATCH v5 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c Philippe Mathieu-Daudé
2024-01-24 21:07 ` Richard Henderson
2024-01-24 7:56 ` [PATCH v5 4/4] accel/tcg: Move perf and debuginfo support to tcg Philippe Mathieu-Daudé
2024-01-24 21:11 ` Richard Henderson
2024-01-25 3:04 ` Ilya Leoshkevich
2024-01-25 4:53 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9cf4786-45d8-49d7-a7d8-44d177a11bf0@linaro.org \
--to=philmd@linaro.org \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).