From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>, <qemu-arm@nongnu.org>,
<qemu-devel@nongnu.org>
Subject: Re: [PATCH] aspeed/sdmc: Drop unnecessary scu include
Date: Tue, 24 Jan 2023 08:29:18 +0100 [thread overview]
Message-ID: <f9e30d2c-51e7-399d-1094-8a01c7ff0d2a@kaod.org> (raw)
In-Reply-To: <20230124062022.298230-1-joel@jms.id.au>
On 1/24/23 07:20, Joel Stanley wrote:
> The model includes aspeed_scu.h but doesn't appear to require it.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/misc/aspeed_sdmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index d2a3931033b3..abb272793393 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -12,7 +12,6 @@
> #include "qemu/module.h"
> #include "qemu/error-report.h"
> #include "hw/misc/aspeed_sdmc.h"
> -#include "hw/misc/aspeed_scu.h"
> #include "hw/qdev-properties.h"
> #include "migration/vmstate.h"
> #include "qapi/error.h"
next prev parent reply other threads:[~2023-01-24 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 6:20 [PATCH] aspeed/sdmc: Drop unnecessary scu include Joel Stanley
2023-01-24 7:29 ` Cédric Le Goater [this message]
2023-01-24 11:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e30d2c-51e7-399d-1094-8a01c7ff0d2a@kaod.org \
--to=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).