* [PATCH] aspeed/sdmc: Drop unnecessary scu include
@ 2023-01-24 6:20 Joel Stanley
2023-01-24 7:29 ` Cédric Le Goater
2023-01-24 11:55 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Joel Stanley @ 2023-01-24 6:20 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: Peter Maydell, qemu-arm, qemu-devel
The model includes aspeed_scu.h but doesn't appear to require it.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
hw/misc/aspeed_sdmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index d2a3931033b3..abb272793393 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -12,7 +12,6 @@
#include "qemu/module.h"
#include "qemu/error-report.h"
#include "hw/misc/aspeed_sdmc.h"
-#include "hw/misc/aspeed_scu.h"
#include "hw/qdev-properties.h"
#include "migration/vmstate.h"
#include "qapi/error.h"
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] aspeed/sdmc: Drop unnecessary scu include
2023-01-24 6:20 [PATCH] aspeed/sdmc: Drop unnecessary scu include Joel Stanley
@ 2023-01-24 7:29 ` Cédric Le Goater
2023-01-24 11:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2023-01-24 7:29 UTC (permalink / raw)
To: Joel Stanley; +Cc: Peter Maydell, qemu-arm, qemu-devel
On 1/24/23 07:20, Joel Stanley wrote:
> The model includes aspeed_scu.h but doesn't appear to require it.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/misc/aspeed_sdmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index d2a3931033b3..abb272793393 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -12,7 +12,6 @@
> #include "qemu/module.h"
> #include "qemu/error-report.h"
> #include "hw/misc/aspeed_sdmc.h"
> -#include "hw/misc/aspeed_scu.h"
> #include "hw/qdev-properties.h"
> #include "migration/vmstate.h"
> #include "qapi/error.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aspeed/sdmc: Drop unnecessary scu include
2023-01-24 6:20 [PATCH] aspeed/sdmc: Drop unnecessary scu include Joel Stanley
2023-01-24 7:29 ` Cédric Le Goater
@ 2023-01-24 11:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-24 11:55 UTC (permalink / raw)
To: Joel Stanley, Cédric Le Goater; +Cc: Peter Maydell, qemu-arm, qemu-devel
On 24/1/23 07:20, Joel Stanley wrote:
> The model includes aspeed_scu.h but doesn't appear to require it.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> hw/misc/aspeed_sdmc.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-24 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-24 6:20 [PATCH] aspeed/sdmc: Drop unnecessary scu include Joel Stanley
2023-01-24 7:29 ` Cédric Le Goater
2023-01-24 11:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).