From: Richard Henderson <richard.henderson@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: david.brenken@efs-auto.de
Subject: Re: [Qemu-devel] [PATCH v2 4/5] target/tricore: Implement a qemu excptions helper
Date: Wed, 21 Aug 2019 16:05:24 -0700 [thread overview]
Message-ID: <fa01ce65-2bf5-1877-bb57-f1baa821ddaa@linaro.org> (raw)
In-Reply-To: <20190821122315.18015-5-kbastian@mail.uni-paderborn.de>
On 8/21/19 5:23 AM, Bastian Koppelmann wrote:
> @@ -3928,7 +3937,7 @@ static void decode_sr_system(DisasContext *ctx)
> ctx->base.is_jmp = DISAS_NORETURN;
> break;
> case OPC2_16_SR_DEBUG:
> - /* raise EXCP_DEBUG */
> + generate_qemu_excp(ctx, EXCP_DEBUG);
> break;
> case OPC2_16_SR_FRET:
> gen_fret(ctx);
> @@ -8354,7 +8363,7 @@ static void decode_sys_interrupts(DisasContext *ctx)
>
> switch (op2) {
> case OPC2_32_SYS_DEBUG:
> - /* raise EXCP_DEBUG */
> + generate_qemu_excp(ctx, EXCP_DEBUG);
> break;
> case OPC2_32_SYS_DISABLE:
> tcg_gen_andi_tl(cpu_ICR, cpu_ICR, ~MASK_ICR_IE_1_3);
This is not correct -- EXCP_DEBUG is an internal qemu exception.
The manual I have only describes the ISA and does not describe what a "Debug
Event" would be. I note that you're missing the DBGSR.DE check. I also note
that whatever a "Debug Event" is, RFM appears to be the return from it. So one
can deduce some things about what it should be.
r~
next prev parent reply other threads:[~2019-08-21 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 12:23 [Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop (resend) Bastian Koppelmann
2019-08-21 12:23 ` [Qemu-devel] [PATCH v2 1/5] target/tricore: Use DisasContextBase API Bastian Koppelmann
2019-08-21 12:23 ` [Qemu-devel] [PATCH v2 2/5] target-tricore: Make env a member of DisasContext Bastian Koppelmann
2019-08-21 12:23 ` [Qemu-devel] [PATCH v2 3/5] target/tricore: Use translate_loop Bastian Koppelmann
2019-08-21 23:06 ` Richard Henderson
2019-08-21 12:23 ` [Qemu-devel] [PATCH v2 4/5] target/tricore: Implement a qemu excptions helper Bastian Koppelmann
2019-08-21 23:05 ` Richard Henderson [this message]
2019-08-21 23:06 ` Richard Henderson
2019-08-21 12:23 ` [Qemu-devel] [PATCH v2 5/5] target/tricore: Fix tricore_tr_translate_insn Bastian Koppelmann
2019-08-21 22:54 ` Richard Henderson
2019-08-21 12:43 ` [Qemu-devel] [PATCH v2 0/5] tricore: Convert to translate_loop (resend) no-reply
2019-08-21 23:08 ` no-reply
2019-08-21 23:19 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa01ce65-2bf5-1877-bb57-f1baa821ddaa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david.brenken@efs-auto.de \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).