From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Huang <wei.huang2@amd.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands
Date: Sat, 25 Apr 2020 12:57:10 +0200 [thread overview]
Message-ID: <fa1c1635-88f4-5bb5-6030-8dec941bf99c@redhat.com> (raw)
In-Reply-To: <20200418042845.596457-1-wei.huang2@amd.com>
On 18/04/20 06:28, Wei Huang wrote:
> Many reserved bits of amd_iommu commands are defined incorrectly in QEMU.
> Because of it, QEMU incorrectly injects lots of illegal commands into guest
> VM's IOMMU event log.
>
> Signed-off-by: Wei Huang <wei.huang2@amd.com>
> ---
> hw/i386/amd_iommu.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index fd75cae02437..4346060e6223 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -370,7 +370,7 @@ static void amdvi_completion_wait(AMDVIState *s, uint64_t *cmd)
> hwaddr addr = cpu_to_le64(extract64(cmd[0], 3, 49)) << 3;
> uint64_t data = cpu_to_le64(cmd[1]);
>
> - if (extract64(cmd[0], 51, 8)) {
> + if (extract64(cmd[0], 52, 8)) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> }
> @@ -395,7 +395,7 @@ static void amdvi_inval_devtab_entry(AMDVIState *s, uint64_t *cmd)
> uint16_t devid = cpu_to_le16((uint16_t)extract64(cmd[0], 0, 16));
>
> /* This command should invalidate internal caches of which there isn't */
> - if (extract64(cmd[0], 15, 16) || cmd[1]) {
> + if (extract64(cmd[0], 16, 44) || cmd[1]) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> }
> @@ -405,9 +405,9 @@ static void amdvi_inval_devtab_entry(AMDVIState *s, uint64_t *cmd)
>
> static void amdvi_complete_ppr(AMDVIState *s, uint64_t *cmd)
> {
> - if (extract64(cmd[0], 15, 16) || extract64(cmd[0], 19, 8) ||
> + if (extract64(cmd[0], 16, 16) || extract64(cmd[0], 52, 8) ||
> extract64(cmd[1], 0, 2) || extract64(cmd[1], 3, 29)
> - || extract64(cmd[1], 47, 16)) {
> + || extract64(cmd[1], 48, 16)) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> }
> @@ -438,8 +438,8 @@ static void amdvi_inval_pages(AMDVIState *s, uint64_t *cmd)
> {
> uint16_t domid = cpu_to_le16((uint16_t)extract64(cmd[0], 32, 16));
>
> - if (extract64(cmd[0], 20, 12) || extract64(cmd[0], 16, 12) ||
> - extract64(cmd[0], 3, 10)) {
> + if (extract64(cmd[0], 20, 12) || extract64(cmd[0], 48, 12) ||
> + extract64(cmd[1], 3, 9)) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> }
> @@ -451,7 +451,7 @@ static void amdvi_inval_pages(AMDVIState *s, uint64_t *cmd)
>
> static void amdvi_prefetch_pages(AMDVIState *s, uint64_t *cmd)
> {
> - if (extract64(cmd[0], 16, 8) || extract64(cmd[0], 20, 8) ||
> + if (extract64(cmd[0], 16, 8) || extract64(cmd[0], 52, 8) ||
> extract64(cmd[1], 1, 1) || extract64(cmd[1], 3, 1) ||
> extract64(cmd[1], 5, 7)) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> @@ -463,7 +463,7 @@ static void amdvi_prefetch_pages(AMDVIState *s, uint64_t *cmd)
>
> static void amdvi_inval_inttable(AMDVIState *s, uint64_t *cmd)
> {
> - if (extract64(cmd[0], 16, 16) || cmd[1]) {
> + if (extract64(cmd[0], 16, 44) || cmd[1]) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> return;
> @@ -479,7 +479,8 @@ static void iommu_inval_iotlb(AMDVIState *s, uint64_t *cmd)
> {
>
> uint16_t devid = extract64(cmd[0], 0, 16);
> - if (extract64(cmd[1], 1, 1) || extract64(cmd[1], 3, 9)) {
> + if (extract64(cmd[1], 1, 1) || extract64(cmd[1], 3, 1) ||
> + extract64(cmd[1], 6, 6)) {
> amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
> s->cmdbuf + s->cmdbuf_head);
> return;
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-04-25 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 4:28 [PATCH] hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands Wei Huang
2020-04-25 10:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1c1635-88f4-5bb5-6030-8dec941bf99c@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).