From: Richard Henderson <rth@twiddle.net>
To: Laurent Vivier <laurent@vivier.eu>,
Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas
Date: Thu, 3 Nov 2016 08:53:16 -0600 [thread overview]
Message-ID: <fa210235-df0f-429c-9ce0-0aa73825460c@twiddle.net> (raw)
In-Reply-To: <1478182068-14082-1-git-send-email-laurent@vivier.eu>
On 11/03/2016 08:07 AM, Laurent Vivier wrote:
> Implement real atomic tas:
>
> When (Rn) = 0, 1 -> T
> Otherwise, 0 -> T
> In both cases, 1 -> MSB of (Rn)
>
> using atomic_fetch_or_i32() and setcondi_i32().
>
> Tested with image from:
> http://wiki.qemu.org/download/sh-test-0.2.tar.bz2
>
> This image contains a "tas_test" that runs without
> error with this change.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> v2:
> - don't use helper but atomic_fetch_or_i32
> Thank yo
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2016-11-03 14:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 14:07 [Qemu-devel] [PATCH v2] target-sh4: add atomic tas Laurent Vivier
2016-11-03 14:53 ` Richard Henderson [this message]
2016-11-03 15:32 ` Paolo Bonzini
2016-11-03 15:35 ` Laurent Vivier
2016-11-03 16:18 ` Paolo Bonzini
2016-11-03 16:21 ` Laurent Vivier
2016-11-03 16:51 ` Laurent Vivier
2016-11-03 16:51 ` Richard Henderson
2016-11-03 17:52 ` Paolo Bonzini
2016-11-03 19:15 ` Richard Henderson
2016-11-04 9:23 ` John Paul Adrian Glaubitz
2016-11-04 9:43 ` John Paul Adrian Glaubitz
2016-11-04 9:53 ` Laurent Vivier
2016-11-04 10:00 ` John Paul Adrian Glaubitz
2016-11-04 10:13 ` Paolo Bonzini
2016-11-04 10:16 ` John Paul Adrian Glaubitz
2016-11-04 10:52 ` Paolo Bonzini
2016-11-04 0:02 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa210235-df0f-429c-9ce0-0aa73825460c@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).