From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43764)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c2JOT-0004j2-EH
	for qemu-devel@nongnu.org; Thu, 03 Nov 2016 10:53:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c2JOQ-0003pj-C3
	for qemu-devel@nongnu.org; Thu, 03 Nov 2016 10:53:29 -0400
Received: from mail-yw0-x235.google.com ([2607:f8b0:4002:c05::235]:34724)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <rth7680@gmail.com>) id 1c2JOQ-0003pQ-7O
	for qemu-devel@nongnu.org; Thu, 03 Nov 2016 10:53:26 -0400
Received: by mail-yw0-x235.google.com with SMTP id t125so49037271ywc.1
	for <qemu-devel@nongnu.org>; Thu, 03 Nov 2016 07:53:25 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1478182068-14082-1-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <fa210235-df0f-429c-9ce0-0aa73825460c@twiddle.net>
Date: Thu, 3 Nov 2016 08:53:16 -0600
MIME-Version: 1.0
In-Reply-To: <1478182068-14082-1-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] target-sh4: add atomic tas
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Paolo Bonzini <pbonzini@redhat.com>

On 11/03/2016 08:07 AM, Laurent Vivier wrote:
> Implement real atomic tas:
>
>     When (Rn) = 0, 1 -> T
>     Otherwise, 0 -> T
>     In both cases, 1 -> MSB of (Rn)
>
> using atomic_fetch_or_i32() and setcondi_i32().
>
> Tested with image from:
> http://wiki.qemu.org/download/sh-test-0.2.tar.bz2
>
> This image contains a "tas_test" that runs without
> error with this change.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> v2:
> - don't use helper but atomic_fetch_or_i32
>   Thank yo

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~