From: David Reiss <dreiss@meta.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH qemu v2 2/3] target/arm/gdbstub: Support reading M system registers from GDB
Date: Tue, 17 Jan 2023 14:45:20 -0800 [thread overview]
Message-ID: <fa222dbf-29cf-219c-95bc-c5c54a87cb79@meta.com> (raw)
In-Reply-To: <cb9cdb62-5c5a-c7de-9fa7-99f5438af332@linaro.org>
On 1/17/23 1:40 PM, Richard Henderson wrote:
>> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
>> index bf2bce046d..fdbb0d9107 100644
>> --- a/target/arm/cpu.h
>> +++ b/target/arm/cpu.h
>> @@ -856,6 +856,7 @@ struct ArchCPU {
>> DynamicGDBXMLInfo dyn_sysreg_xml;
>> DynamicGDBXMLInfo dyn_svereg_xml;
>> + DynamicGDBXMLInfo dyn_m_systemreg_xml;
>
> You don't need a new variable here, because a given cpu cannot be both a-profile and m-profile -- dyn_sysreg_xml can hold the xml for the current set of system registers.
Maybe I'm missing something? It looks like arm_cpu_register_gdb_regs_for_features
unconditionally calls
gdb_register_coprocessor(..., arm_gen_dynamic_sysreg_xml(...), ...);
which would cause a collision.
next prev parent reply other threads:[~2023-01-17 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 19:44 [PATCH qemu v2 0/3] ARM: Add support for V8M special registers in GDB stub ~dreiss-meta
2023-01-09 23:05 ` [PATCH qemu v2 1/3] target/arm: Unify checking for M Main Extension in MRS/MSR ~dreiss-meta
2023-01-09 23:05 ` [PATCH qemu v2 2/3] target/arm/gdbstub: Support reading M system registers from GDB ~dreiss-meta
2023-01-17 21:40 ` Richard Henderson
2023-01-17 22:45 ` David Reiss [this message]
2023-01-09 23:05 ` [PATCH qemu v2 3/3] target/arm/gdbstub: Support reading M security extension " ~dreiss-meta
2023-01-17 21:42 ` Richard Henderson
2023-01-17 22:48 ` David Reiss
2023-01-19 13:58 ` Peter Maydell
2023-02-03 11:38 ` [PATCH qemu v2 0/3] ARM: Add support for V8M special registers in GDB stub Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa222dbf-29cf-219c-95bc-c5c54a87cb79@meta.com \
--to=dreiss@meta.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).