From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NEq-0007zo-JM for qemu-devel@nongnu.org; Wed, 26 Apr 2017 09:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3NEm-0001Fn-7T for qemu-devel@nongnu.org; Wed, 26 Apr 2017 09:44:09 -0400 References: <20170225193155.447462-1-vsementsov@virtuozzo.com> <20170225193155.447462-3-vsementsov@virtuozzo.com> <20170307100204.GC5871@noname.str.redhat.com> <20170426122246.v2px6y33k4dpiiqb@eukaryote> From: Vladimir Sementsov-Ogievskiy Message-ID: Date: Wed, 26 Apr 2017 16:43:52 +0300 MIME-Version: 1.0 In-Reply-To: <20170426122246.v2px6y33k4dpiiqb@eukaryote> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy Cc: Kevin Wolf , peter.maydell@linaro.org, famz@redhat.com, lirans@il.ibm.com, qemu-block@nongnu.org, quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, dgilbert@redhat.com 26.04.2017 15:22, Kashyap Chamarthy wrote: > On Tue, Mar 07, 2017 at 01:11:23PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> 07.03.2017 13:02, Kevin Wolf wrote: >>> Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben: >>>> We must invalidate on RUN_STATE_PRELAUNCH too, as it is available >>>> through qmp_system_reset from RUN_STATE_POSTMIGRATE. Otherwise, we will >>>> come to >>>> >>>> qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: >>>> Assertion `!(bs->open_flags & 0x0800)' failed. >>>> >>>> on the first write after vm start. >>>> >>>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> Wouldn't it make more sense to invalidate in qmp_system_reset() where >>> the migration states are left? >>> >>> Or maybe BDRV_O_INACTIVE could even be tied directly to runstates? Not >>> sure how realistic this one is, but if we start adding invalidate_cache >>> calls all over the place, maybe that's a sign that we need to look for a >>> more central place. >> I've proposed it in cover letter) These bugs and my fixes are just show that >> something should be rethought.. I don't claim that these fixes are true way, >> they are just the simplest. > Hi Vladimir, > > I wonder if you have a new version of your patch ("qmp-cont: invalidate > on RUN_STATE_PRELAUNCH"). > > Hailiang Zhang tells me on this the below thread that your patch fixes > the issue: > > http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg03925.html > -- [QEMU-2.8] Source QEMU crashes with: "bdrv_co_pwritev: Assertion > `!(bs->open_flags & BDRV_O_INACTIVE)' failed" > No, I haven't new version, discussion is unfinished about true way of doing it. This version is ok with the case it fixes. -- Best regards, Vladimir