Re: [PATCH for-8.1 3/3] target/arm/ptw.c: Account for FEAT_RME when applying {N}SW,SA bits

[Richard Henderson <richard.henderson@linaro.org>]

On 7/10/23 16:21, Peter Maydell wrote:
> In get_phys_addr_twostage() the code that applies the effects of
> VSTCR.{SA,SW} and VTCR.{NSA,NSW} only updates result->f.attrs.secure.
> Now we also have f.attrs.space for FEAT_RME, we need to keep the two
> in sync.
> 
> These bits only have an effect for Secure space translations, not
> for Root, so use the input in_space field to determine whether to
> apply them rather than the input is_secure. This doesn't actually
> make a difference because Root translations are never two-stage,
> but it's a little clearer.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> I noticed this while reading through the ptw code...
> ---
>   target/arm/ptw.c | 13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~