From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation
Date: Tue, 6 Nov 2018 13:54:12 -0200 [thread overview]
Message-ID: <fa37541c-a2a8-8bbc-6114-e15b650da020@gmail.com> (raw)
In-Reply-To: <20181029173437.32559-1-pbonzini@redhat.com>
Hi,
How did you find all those issues, Max? First patch is something that
I missed out from the SCSI spec (ordering of the VPD pages)
and could have been detected by code inspection, but I am curious about
the other fixes.
Thanks,
Daniel
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
> scsi-generic (pass through) devices are able to inject an artificial Block
> Limits VPD page in order to communicate host HBA limits to the guest.
> However, Max Reitz found a few issues with the implementation of this
> feature; this series should fix them all.
>
> Paolo
>
> Paolo Bonzini (4):
> scsi-generic: keep VPD page list sorted
> scsi-generic: avoid out-of-bounds access to VPD page list
> scsi-generic: avoid invalid access to struct when emulating block
> limits
> scsi-generic: do not do VPD emulation for sense other than
> ILLEGAL_REQUEST
>
> hw/scsi/Makefile.objs | 2 +-
> hw/scsi/emulation.c | 42 +++++++++++++++++
> hw/scsi/scsi-disk.c | 92 ++++++++-----------------------------
> hw/scsi/scsi-generic.c | 51 +++++++++++++++-----
> include/hw/scsi/emulation.h | 16 +++++++
> include/hw/scsi/scsi.h | 1 -
> 6 files changed, 119 insertions(+), 85 deletions(-)
> create mode 100644 hw/scsi/emulation.c
> create mode 100644 include/hw/scsi/emulation.h
>
next prev parent reply other threads:[~2018-11-06 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:34 [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation Paolo Bonzini
2018-10-29 17:34 ` [Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted Paolo Bonzini
2018-11-06 1:45 ` Max Reitz
2018-11-06 15:39 ` Daniel Henrique Barboza
2018-10-29 17:34 ` [Qemu-devel] [PATCH 2/4] scsi-generic: avoid out-of-bounds access to VPD page list Paolo Bonzini
2018-10-30 21:26 ` Philippe Mathieu-Daudé
2018-11-06 1:52 ` Max Reitz
2018-11-06 15:40 ` Daniel Henrique Barboza
2018-10-29 17:34 ` [Qemu-devel] [PATCH 3/4] scsi-generic: avoid invalid access to struct when emulating block limits Paolo Bonzini
2018-11-06 2:16 ` Max Reitz
2018-11-06 9:44 ` Paolo Bonzini
2018-10-29 17:34 ` [Qemu-devel] [PATCH 4/4] scsi-generic: do not do VPD emulation for sense other than ILLEGAL_REQUEST Paolo Bonzini
2018-11-06 2:22 ` Max Reitz
2018-10-31 23:17 ` [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation no-reply
2018-10-31 23:27 ` no-reply
2018-11-06 15:31 ` no-reply
2018-11-06 15:42 ` no-reply
2018-11-06 15:54 ` Daniel Henrique Barboza [this message]
2018-11-06 18:54 ` Paolo Bonzini
2018-11-07 11:36 ` no-reply
2018-11-07 11:46 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa37541c-a2a8-8bbc-6114-e15b650da020@gmail.com \
--to=danielhb413@gmail.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).