From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJeMz-0001HC-NX for qemu-devel@nongnu.org; Wed, 21 Dec 2016 05:43:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJeMv-0004kP-JP for qemu-devel@nongnu.org; Wed, 21 Dec 2016 05:43:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42222) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJeMv-0004k3-DX for qemu-devel@nongnu.org; Wed, 21 Dec 2016 05:43:33 -0500 References: <1479108340-3453-1-git-send-email-caoj.fnst@cn.fujitsu.com> <585A1E33.1090002@cn.fujitsu.com> From: Marcel Apfelbaum Message-ID: Date: Wed, 21 Dec 2016 12:43:30 +0200 MIME-Version: 1.0 In-Reply-To: <585A1E33.1090002@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Markus Armbruster On 12/21/2016 08:16 AM, Cao jin wrote: > ping > Misses the Acked-by: Marcel Apfelbaum from V6, if it helps. Thanks, Marcel > On 11/14/2016 03:25 PM, Cao jin wrote: >> v7 changelog: >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >> please take a look, there is detailed description in the patch. >> 2. add the R-b from Hannes Reinecke >> >> Test: >> 1. make check: pass >> 2. After applied all the patch, command line test for all the >> affected devices, just make sure device realize process is ok, >> no crash, but no further use of device. >> >> CC: Jiri Pirko >> CC: Gerd Hoffmann >> CC: Dmitry Fleytman >> CC: Jason Wang >> CC: Michael S. Tsirkin >> CC: Hannes Reinecke >> CC: Paolo Bonzini >> CC: Alex Williamson >> CC: Markus Armbruster >> CC: Marcel Apfelbaum >> >> Cao jin (10): >> msix: Follow CODING_STYLE >> hcd-xhci: check & correct param before using it >> pci: Convert msix_init() to Error and fix callers to check it >> megasas: change behaviour of msix switch >> hcd-xhci: change behaviour of msix switch >> megasas: remove unnecessary megasas_use_msix() >> megasas: undo the overwrites of msi user configuration >> vmxnet3: fix reference leak issue >> vmxnet3: remove unnecessary internal msix flag >> msi_init: convert assert to return -errno >> >> hw/block/nvme.c | 5 +++- >> hw/misc/ivshmem.c | 8 +++--- >> hw/net/e1000e.c | 6 ++++- >> hw/net/rocker/rocker.c | 7 ++++- >> hw/net/vmxnet3.c | 46 +++++++++++++++------------------ >> hw/pci/msi.c | 9 ++++--- >> hw/pci/msix.c | 42 +++++++++++++++++++++++++----- >> hw/scsi/megasas.c | 49 ++++++++++++++++++++--------------- >> hw/usb/hcd-xhci.c | 69 ++++++++++++++++++++++++++++++-------------------- >> hw/vfio/pci.c | 8 ++++-- >> hw/virtio/virtio-pci.c | 11 ++++---- >> include/hw/pci/msix.h | 5 ++-- >> 12 files changed, 164 insertions(+), 101 deletions(-) >> >