From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Anup Patel <anup@brainfault.org>, Bin Meng <bmeng.cn@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Palmer Dabbelt <palmerdabbelt@google.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <Alistair.Francis@wdc.com>
Subject: Re: [PATCH 1/2] riscv: roms: Add 32-bit OpenSBI firmware image for sifive_u
Date: Fri, 21 Feb 2020 09:54:45 +0100 [thread overview]
Message-ID: <fa5088d2-2f9a-6df6-3d34-d8c0c7c34df0@redhat.com> (raw)
In-Reply-To: <CAAhSdy0edkypzbhhLw2g52F2w6GrS46OKi461Fghuk5AZfCjgQ@mail.gmail.com>
On 2/21/20 6:54 AM, Anup Patel wrote:
> On Fri, Feb 21, 2020 at 8:08 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> Hi Philippe,
>>
>> On Fri, Feb 21, 2020 at 1:31 AM Philippe Mathieu-Daudé
>> <philmd@redhat.com> wrote:
>>>
>>> Hi Bin,
>>>
>>> On 2/20/20 3:42 PM, Bin Meng wrote:
>>>> Although the real world SiFive HiFive Unleashed board is a 64-bit
>>>> hardware configuration, with QEMU it is possible to test 32-bit
>>>> configuration with the same hardware features.
>>>>
>>>> This updates the roms Makefile to add the build rules for creating
>>>> the 32-bit OpenSBI firmware image for sifive_u machine. A pre-built
>>>> OpenSBI image (built from commit 3e7d666) has been added as the
>>>> default bios for 32-bit sifive_u machine.
>>>
>>> With QEMU:
>>>
>>> fatal: ambiguous argument '3e7d666': unknown revision or path not in the
>>> working tree.
>>>
>>> This looks like an OpenSBI commit but QEMU only include up to v0.5.
>>>
>>> Can you build v0.5? Else can you update the submodule?
>>>
>>
>> Will do in v2.
>
> We plan to release OpenSBI v0.6 on monday (24th Feb 2020) so maybe
> you can update all RISC-V ROM images based on OpenSBI v0.6 ??
Sounds cleaner.
Suggestions when updating a QEMU git-submodule:
- Include output of submodule 'git-log --reverse --oneline'
- Send series/pull-request with 'git-format-patch --no-binary'
>
>>
>>> Also, can you add a CI job to build this, so we have reproducible builds
>>> (see QEMU commit 71920809ceabed as example)?
>>
>> I cannot find any document for how to test CI job with gitlab CI. Does
>> QEMU has a public CI runner for testing?
There is:
https://wiki.qemu.org/Testing
https://wiki.qemu.org/Testing/CI
Currently you can use whatever CI best suits you (although long term is
probably to rely more on GitLab, because it allows adding runners on
particular hardware/setup).
>>
>> Regards,
>> Bin
>>
>
> Regards,
> Anup
>
next prev parent reply other threads:[~2020-02-21 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:42 [PATCH 1/2] riscv: roms: Add 32-bit OpenSBI firmware image for sifive_u Bin Meng
2020-02-20 14:42 ` [PATCH 2/2] riscv: sifive_u: Update BIOS_FILENAME for 32-bit Bin Meng
2020-02-21 19:51 ` Alistair Francis
2020-02-22 2:52 ` Bin Meng
2020-02-22 3:55 ` Alistair Francis
2020-02-20 17:31 ` [PATCH 1/2] riscv: roms: Add 32-bit OpenSBI firmware image for sifive_u Philippe Mathieu-Daudé
2020-02-21 2:38 ` Bin Meng
2020-02-21 5:54 ` Anup Patel
2020-02-21 8:54 ` Philippe Mathieu-Daudé [this message]
2020-02-22 14:53 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa5088d2-2f9a-6df6-3d34-d8c0c7c34df0@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=anup@brainfault.org \
--cc=bmeng.cn@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmerdabbelt@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).