From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org, jcmvbkbc@gmail.com,
kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp,
gaosong@loongson.cn, jiaxun.yang@flygoat.com,
tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com,
edgar.iglesias@gmail.com
Subject: Re: [PATCH 74/76] tracing: remove transform.py
Date: Sat, 25 Feb 2023 07:52:15 -0300 [thread overview]
Message-ID: <fa6854b1-01fe-165d-8db6-4bef53c09f8c@gmail.com> (raw)
In-Reply-To: <c12cd821-59e5-36c3-0231-f81e3a4e1433@ventanamicro.com>
On 2/25/23 07:22, Daniel Henrique Barboza wrote:
> Richard,
>
> Not sure if I forgot or missed something but this patch breaks my build as follows:
Nevermind, just did it again to test the powerpc changes and it worked. I probably
goofed something the first time.
Daniel
>
> $ make -j
> GIT ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc
> [1/885] Generating trace/trace-hw_hyperv.c with a custom command
> FAILED: trace/trace-hw_hyperv.c
> /usr/bin/python3 ../scripts/tracetool.py --backend=log --group=hw_hyperv --format=c /home/danielhb/work/qemu/hw/hyperv/trace-events trace/trace-hw_hyperv.c
> Traceback (most recent call last):
> File "/home/danielhb/work/qemu/build/../scripts/tracetool.py", line 19, in <module>
> from tracetool import error_write, out, out_open
> File "/home/danielhb/work/qemu/scripts/tracetool/__init__.py", line 21, in <module>
> import tracetool.transform
> ModuleNotFoundError: No module named 'tracetool.transform'
>
>
> It seems that tracetool.py is still referring transform. This fixes the build
> for me:
>
> $ git diff
> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 5393c7fc5c..c361815bc1 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -18,7 +18,6 @@
>
> import tracetool.format
> import tracetool.backend
> -import tracetool.transform
>
>
> def error_write(*lines):
>
>
> For reference I grabbed and built the whole series from patchew:
>
> https://patchew.org/QEMU/20230225091427.1817156-1-richard.henderson@linaro.org/
>
>
>
> Thanks,
>
>
> Daniel
>
>
> On 2/25/23 06:14, Richard Henderson wrote:
>> This file got left behind when the tcg stuff was
>> removed from tracetool.
>>
>> Fixes: 126d4123c50a ("tracing: excise the tcg related from tracetool")
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> meson.build | 1 -
>> scripts/tracetool/transform.py | 168 ---------------------------------
>> 2 files changed, 169 deletions(-)
>> delete mode 100644 scripts/tracetool/transform.py
>>
>> diff --git a/meson.build b/meson.build
>> index 6cb2b1a42f..275399b8c2 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -2861,7 +2861,6 @@ tracetool_depends = files(
>> 'scripts/tracetool/format/log_stap.py',
>> 'scripts/tracetool/format/stap.py',
>> 'scripts/tracetool/__init__.py',
>> - 'scripts/tracetool/transform.py',
>> 'scripts/tracetool/vcpu.py'
>> )
>> diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
>> deleted file mode 100644
>> index ea8b27799d..0000000000
>> --- a/scripts/tracetool/transform.py
>> +++ /dev/null
>> @@ -1,168 +0,0 @@
>> -# -*- coding: utf-8 -*-
>> -
>> -"""
>> -Type-transformation rules.
>> -"""
>> -
>> -__author__ = "Lluís Vilanova <vilanova@ac.upc.edu>"
>> -__copyright__ = "Copyright 2012-2016, Lluís Vilanova <vilanova@ac.upc.edu>"
>> -__license__ = "GPL version 2 or (at your option) any later version"
>> -
>> -__maintainer__ = "Stefan Hajnoczi"
>> -__email__ = "stefanha@redhat.com"
>> -
>> -
>> -def _transform_type(type_, trans):
>> - if isinstance(trans, str):
>> - return trans
>> - elif isinstance(trans, dict):
>> - if type_ in trans:
>> - return _transform_type(type_, trans[type_])
>> - elif None in trans:
>> - return _transform_type(type_, trans[None])
>> - else:
>> - return type_
>> - elif callable(trans):
>> - return trans(type_)
>> - else:
>> - raise ValueError("Invalid type transformation rule: %s" % trans)
>> -
>> -
>> -def transform_type(type_, *trans):
>> - """Return a new type transformed according to the given rules.
>> -
>> - Applies each of the transformation rules in trans in order.
>> -
>> - If an element of trans is a string, return it.
>> -
>> - If an element of trans is a function, call it with type_ as its only
>> - argument.
>> -
>> - If an element of trans is a dict, search type_ in its keys. If type_ is
>> - a key, use the value as a transformation rule for type_. Otherwise, if
>> - None is a key use the value as a transformation rule for type_.
>> -
>> - Otherwise, return type_.
>> -
>> - Parameters
>> - ----------
>> - type_ : str
>> - Type to transform.
>> - trans : list of function or dict
>> - Type transformation rules.
>> - """
>> - if len(trans) == 0:
>> - raise ValueError
>> - res = type_
>> - for t in trans:
>> - res = _transform_type(res, t)
>> - return res
>> -
>> -
>> -##################################################
>> -# tcg -> host
>> -
>> -def _tcg_2_host(type_):
>> - if type_ == "TCGv":
>> - # force a fixed-size type (target-independent)
>> - return "uint64_t"
>> - else:
>> - return type_
>> -
>> -TCG_2_HOST = {
>> - "TCGv_i32": "uint32_t",
>> - "TCGv_i64": "uint64_t",
>> - "TCGv_ptr": "void *",
>> - None: _tcg_2_host,
>> - }
>> -
>> -
>> -##################################################
>> -# host -> host compatible with tcg sizes
>> -
>> -HOST_2_TCG_COMPAT = {
>> - "uint8_t": "uint32_t",
>> - "uint16_t": "uint32_t",
>> - }
>> -
>> -
>> -##################################################
>> -# host/tcg -> tcg
>> -
>> -def _host_2_tcg(type_):
>> - if type_.startswith("TCGv"):
>> - return type_
>> - raise ValueError("Don't know how to translate '%s' into a TCG type\n" % type_)
>> -
>> -HOST_2_TCG = {
>> - "uint32_t": "TCGv_i32",
>> - "uint64_t": "TCGv_i64",
>> - "void *" : "TCGv_ptr",
>> - "CPUArchState *": "TCGv_env",
>> - None: _host_2_tcg,
>> - }
>> -
>> -
>> -##################################################
>> -# tcg -> tcg helper definition
>> -
>> -def _tcg_2_helper_def(type_):
>> - if type_ == "TCGv":
>> - return "target_ulong"
>> - else:
>> - return type_
>> -
>> -TCG_2_TCG_HELPER_DEF = {
>> - "TCGv_i32": "uint32_t",
>> - "TCGv_i64": "uint64_t",
>> - "TCGv_ptr": "void *",
>> - None: _tcg_2_helper_def,
>> - }
>> -
>> -
>> -##################################################
>> -# tcg -> tcg helper declaration
>> -
>> -def _tcg_2_tcg_helper_decl_error(type_):
>> - raise ValueError("Don't know how to translate type '%s' into a TCG helper declaration type\n" % type_)
>> -
>> -TCG_2_TCG_HELPER_DECL = {
>> - "TCGv" : "tl",
>> - "TCGv_ptr": "ptr",
>> - "TCGv_i32": "i32",
>> - "TCGv_i64": "i64",
>> - "TCGv_env": "env",
>> - None: _tcg_2_tcg_helper_decl_error,
>> - }
>> -
>> -
>> -##################################################
>> -# host/tcg -> tcg temporal constant allocation
>> -
>> -def _host_2_tcg_tmp_new(type_):
>> - if type_.startswith("TCGv"):
>> - return "tcg_temp_new_nop"
>> - raise ValueError("Don't know how to translate type '%s' into a TCG temporal allocation" % type_)
>> -
>> -HOST_2_TCG_TMP_NEW = {
>> - "uint32_t": "tcg_const_i32",
>> - "uint64_t": "tcg_const_i64",
>> - "void *" : "tcg_const_ptr",
>> - None: _host_2_tcg_tmp_new,
>> - }
>> -
>> -
>> -##################################################
>> -# host/tcg -> tcg temporal constant deallocation
>> -
>> -def _host_2_tcg_tmp_free(type_):
>> - if type_.startswith("TCGv"):
>> - return "tcg_temp_free_nop"
>> - raise ValueError("Don't know how to translate type '%s' into a TCG temporal deallocation" % type_)
>> -
>> -HOST_2_TCG_TMP_FREE = {
>> - "uint32_t": "tcg_temp_free_i32",
>> - "uint64_t": "tcg_temp_free_i64",
>> - "void *" : "tcg_temp_free_ptr",
>> - None: _host_2_tcg_tmp_free,
>> - }
>
next prev parent reply other threads:[~2023-02-25 10:53 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 9:13 [PATCH 00/76] tcg: Drop tcg_temp_free from translators Richard Henderson
2023-02-25 9:13 ` [PATCH 01/76] tcg: Remove tcg_check_temp_count, tcg_clear_temp_count Richard Henderson
2023-02-25 9:13 ` [PATCH 02/76] accel/tcg: Remove translator_loop_temp_check Richard Henderson
2023-02-25 9:13 ` [PATCH 03/76] target/alpha: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 04/76] target/arm: Remove arm_free_cc, a64_free_cc Richard Henderson
2023-02-25 9:13 ` [PATCH 05/76] target/arm: Remove value_global from DisasCompare Richard Henderson
2023-02-25 9:13 ` [PATCH 06/76] target/arm: Drop tcg_temp_free from translator.c Richard Henderson
2023-02-25 9:13 ` [PATCH 07/76] target/arm: Drop DisasContext.tmp_a64 Richard Henderson
2023-02-25 9:13 ` [PATCH 08/76] target/arm: Drop new_tmp_a64 Richard Henderson
2023-02-25 9:13 ` [PATCH 09/76] target/arm: Drop new_tmp_a64_zero Richard Henderson
2023-02-25 9:13 ` [PATCH 10/76] target/arm: Drop tcg_temp_free from translator-a64.c Richard Henderson
2023-02-25 9:13 ` [PATCH 11/76] target/arm: Drop tcg_temp_free from translator-m-nocp.c Richard Henderson
2023-02-25 9:13 ` [PATCH 12/76] target/arm: Drop tcg_temp_free from translator-mve.c Richard Henderson
2023-02-25 9:13 ` [PATCH 13/76] target/arm: Drop tcg_temp_free from translator-neon.c Richard Henderson
2023-02-25 9:13 ` [PATCH 14/76] target/arm: Drop tcg_temp_free from translator-sme.c Richard Henderson
2023-02-25 9:13 ` [PATCH 15/76] target/arm: Drop tcg_temp_free from translator-sve.c Richard Henderson
2023-02-25 9:13 ` [PATCH 16/76] target/arm: Drop tcg_temp_free from translator-vfp.c Richard Henderson
2023-02-25 9:13 ` [PATCH 17/76] target/arm: Drop tcg_temp_free from translator.h Richard Henderson
2023-02-25 9:13 ` [PATCH 18/76] target/avr: Drop DisasContext.free_skip_var0 Richard Henderson
2023-02-25 9:13 ` [PATCH 19/76] target/avr: Drop R from trans_COM Richard Henderson
2023-02-25 9:13 ` [PATCH 20/76] target/avr: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 21/76] target/cris: Drop cris_alu_free_temps Richard Henderson
2023-02-25 9:13 ` [PATCH 22/76] target/cris: Drop cris_alu_m_free_temps Richard Henderson
2023-02-25 9:13 ` [PATCH 23/76] target/cris: Drop addr from dec10_ind_move_m_pr Richard Henderson
2023-02-25 9:13 ` [PATCH 24/76] target/cris: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 25/76] target/cris: Drop tcg_temp_free from C code Richard Henderson
2023-02-25 9:17 ` Richard Henderson
2023-02-25 9:13 ` [PATCH 26/76] target/cris: Drop tcg_temp_free from gen_tcg_funcs.py Richard Henderson
2023-02-25 9:18 ` Richard Henderson
2023-02-25 9:13 ` [PATCH 27/76] target/hexagon/idef-parser: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 28/76] target/hexagon/idef-parser: Drop HexValue.is_manual Richard Henderson
2023-02-25 9:13 ` [PATCH 29/76] target/hppa: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 30/76] target/i386: " Richard Henderson
2023-02-25 9:13 ` [PATCH 31/76] target/loongarch: Drop temp_new Richard Henderson
2023-02-27 3:17 ` gaosong
2023-02-25 9:13 ` [PATCH 32/76] target/loongarch: Drop tcg_temp_free Richard Henderson
2023-02-27 3:18 ` gaosong
2023-02-25 9:13 ` [PATCH 33/76] target/m68k: Drop mark_to_release Richard Henderson
2023-02-25 9:13 ` [PATCH 34/76] target/m68k: Drop free_cond Richard Henderson
2023-02-25 9:13 ` [PATCH 35/76] target/m68k: Drop tcg_temp_free Richard Henderson
2023-02-25 9:13 ` [PATCH 36/76] target/microblaze: " Richard Henderson
2023-02-25 9:13 ` [PATCH 37/76] target/mips: Drop tcg_temp_free from micromips_translate.c.inc Richard Henderson
2023-02-25 9:13 ` [PATCH 38/76] target/mips: Drop tcg_temp_free from mips16e_translate.c.inc Richard Henderson
2023-02-25 9:13 ` [PATCH 39/76] target/mips: Drop tcg_temp_free from msa_translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 40/76] target/mips: Drop tcg_temp_free from mxu_translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 41/76] target/mips: Drop tcg_temp_free from nanomips_translate.c.inc Richard Henderson
2023-02-25 9:13 ` [PATCH 42/76] target/mips: Drop tcg_temp_free from octeon_translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 43/76] target/mips: Drop tcg_temp_free from translate_addr_const.c Richard Henderson
2023-02-25 9:13 ` [PATCH 44/76] target/mips: Drop tcg_temp_free from tx79_translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 45/76] target/mips: Fix trans_mult_acc return Richard Henderson
2023-02-25 19:47 ` Philippe Mathieu-Daudé
2023-02-25 9:13 ` [PATCH 46/76] target/mips: Drop tcg_temp_free from vr54xx_translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 47/76] target/mips: Drop tcg_temp_free from translate.c Richard Henderson
2023-02-25 9:13 ` [PATCH 48/76] target/nios2: Drop tcg_temp_free Richard Henderson
2023-02-25 9:14 ` [PATCH 49/76] target/openrisc: " Richard Henderson
2023-02-25 9:14 ` [PATCH 50/76] target/ppc: " Richard Henderson
2023-02-25 10:52 ` Daniel Henrique Barboza
2023-02-25 9:14 ` [PATCH 51/76] target/riscv: Drop ftemp_new Richard Henderson
2023-02-25 10:33 ` Daniel Henrique Barboza
2023-02-26 12:58 ` liweiwei
2023-02-26 13:01 ` liweiwei
2023-02-25 9:14 ` [PATCH 52/76] target/riscv: Drop temp_new Richard Henderson
2023-02-25 10:33 ` Daniel Henrique Barboza
2023-02-26 13:00 ` liweiwei
2023-02-25 9:14 ` [PATCH 53/76] target/riscv: Drop tcg_temp_free Richard Henderson
2023-02-25 10:33 ` Daniel Henrique Barboza
2023-02-26 13:04 ` liweiwei
2023-02-25 9:14 ` [PATCH 54/76] target/rx: " Richard Henderson
2023-02-25 9:14 ` [PATCH 55/76] target/s390x: Use tcg_constant_* in local contexts Richard Henderson
2023-02-25 9:14 ` [PATCH 56/76] target/s390x: Use tcg_constant_* for DisasCompare Richard Henderson
2023-02-25 9:14 ` [PATCH 57/76] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34 Richard Henderson
2023-02-25 9:14 ` [PATCH 58/76] target/s390x: Use tcg_constant_* in translate_vx.c.inc Richard Henderson
2023-02-25 9:14 ` [PATCH 59/76] target/s390x: Drop free_compare Richard Henderson
2023-02-25 9:14 ` [PATCH 60/76] target/s390x: Drop tcg_temp_free from translate_vx.c.inc Richard Henderson
2023-02-25 9:14 ` [PATCH 61/76] target/s390x: Drop tcg_temp_free from translate.c Richard Henderson
2023-02-25 9:14 ` [PATCH 62/76] target/s390x: Remove assert vs g_in2 Richard Henderson
2023-02-25 9:14 ` [PATCH 63/76] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext Richard Henderson
2023-02-25 9:14 ` [PATCH 64/76] target/sh4: Drop tcg_temp_free Richard Henderson
2023-02-25 9:14 ` [PATCH 65/76] target/sparc: Drop get_temp_tl Richard Henderson
2023-02-25 9:14 ` [PATCH 66/76] target/sparc: Drop get_temp_i32 Richard Henderson
2023-03-03 19:06 ` Peter Maydell
2023-02-25 9:14 ` [PATCH 67/76] target/sparc: Remove egress label in disas_sparc_context Richard Henderson
2023-02-25 9:14 ` [PATCH 68/76] target/sparc: Drop free_compare Richard Henderson
2023-02-25 9:14 ` [PATCH 69/76] target/sparc: Drop tcg_temp_free Richard Henderson
2023-02-25 9:14 ` [PATCH 70/76] target/tricore: " Richard Henderson
2023-02-25 9:14 ` [PATCH 71/76] target/sparc: Drop reset_sar_tracker Richard Henderson
2023-02-25 9:39 ` Max Filippov
2023-02-25 9:14 ` [PATCH 72/76] target/xtensa: Drop tcg_temp_free Richard Henderson
2023-02-25 9:41 ` Max Filippov
2023-02-25 9:14 ` [PATCH 73/76] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start Richard Henderson
2023-02-25 9:14 ` [PATCH 74/76] tracing: remove transform.py Richard Henderson
2023-02-25 10:22 ` Daniel Henrique Barboza
2023-02-25 10:52 ` Daniel Henrique Barboza [this message]
2023-02-25 18:38 ` Richard Henderson
2023-02-27 3:03 ` gaosong
2023-02-25 10:53 ` Daniel Henrique Barboza
2023-02-25 9:14 ` [PATCH 75/76] tcg: Create tcg/tcg-temp-internal.h Richard Henderson
2023-02-25 9:14 ` [PATCH 76/76] docs/devel/tcg-ops: Drop recommendation to free temps Richard Henderson
2023-02-25 10:55 ` Daniel Henrique Barboza
2023-02-25 10:10 ` [PATCH 00/76] tcg: Drop tcg_temp_free from translators Philippe Mathieu-Daudé
2023-02-25 10:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa6854b1-01fe-165d-8db6-4bef53c09f8c@gmail.com \
--to=danielhb413@gmail.com \
--cc=ale@rev.ng \
--cc=edgar.iglesias@gmail.com \
--cc=gaosong@loongson.cn \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mrolnik@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).