From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Matthew Garrett <mjg59@coreos.com>
Cc: qemu-devel@nongnu.org, berrange@redhat.com, stefanb@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware
Date: Fri, 30 Sep 2016 13:03:19 +0200 [thread overview]
Message-ID: <fa762b83-39b0-b47d-29dd-5498bcaa52fa@redhat.com> (raw)
In-Reply-To: <20160930104558.GC2095@work-vm>
On 30/09/2016 12:45, Dr. David Alan Gilbert wrote:
>> >
>> > This version of the implementation depends on port io, but if there's
>> > interest I'll add mmio as well.
> Other than a couple of nits I'll mention below (and Stefan's comment)
> I don't see why we shouldn't have this; although we'll need a full vTPM
> for many uses, this is small and self-contained enough I can't
> see why not to have it. I'd also be tempted to prefix the commands in
> both qmp and hmp by an x- (i.e. mark experimental) so that you have the
> freedom to change them after it goes in initially
>
> Paolo: Does the acpi stuff make sense?
I think I'd prefer to use a QEMUxxxx identifier if it's not a problem
for Matthew, but that's really all I have to complain about it.
Paolo
prev parent reply other threads:[~2016-09-30 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 19:48 [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware Matthew Garrett
2016-09-12 0:05 ` Stefan Berger
2016-09-30 10:45 ` Dr. David Alan Gilbert
2016-09-30 11:03 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa762b83-39b0-b47d-29dd-5498bcaa52fa@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mjg59@coreos.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).