From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpvbE-0004q1-31 for qemu-devel@nongnu.org; Fri, 30 Sep 2016 07:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpvbA-0003RD-UY for qemu-devel@nongnu.org; Fri, 30 Sep 2016 07:03:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpvbA-0003R5-O0 for qemu-devel@nongnu.org; Fri, 30 Sep 2016 07:03:24 -0400 References: <1471463332-12274-1-git-send-email-mjg59@coreos.com> <20160930104558.GC2095@work-vm> From: Paolo Bonzini Message-ID: Date: Fri, 30 Sep 2016 13:03:19 +0200 MIME-Version: 1.0 In-Reply-To: <20160930104558.GC2095@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Matthew Garrett Cc: qemu-devel@nongnu.org, berrange@redhat.com, stefanb@us.ibm.com On 30/09/2016 12:45, Dr. David Alan Gilbert wrote: >> > >> > This version of the implementation depends on port io, but if there's >> > interest I'll add mmio as well. > Other than a couple of nits I'll mention below (and Stefan's comment) > I don't see why we shouldn't have this; although we'll need a full vTPM > for many uses, this is small and self-contained enough I can't > see why not to have it. I'd also be tempted to prefix the commands in > both qmp and hmp by an x- (i.e. mark experimental) so that you have the > freedom to change them after it goes in initially > > Paolo: Does the acpi stuff make sense? I think I'd prefer to use a QEMUxxxx identifier if it's not a problem for Matthew, but that's really all I have to complain about it. Paolo